Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: Kieran Kunhya via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: FFmpeg development discussions and patches <ffmpeg-devel@ffmpeg.org>
Cc: Michael Niedermayer <michael@niedermayer.cc>,
	Kieran Kunhya <kieran618@googlemail.com>
Subject: [FFmpeg-devel] Re: [PATCH] avformat/mpegtsenc: Limit TS invalid messages
Date: Mon, 6 Oct 2025 14:53:49 +0900
Message-ID: <CABGuwEkA76TYGKN-5OWqSK_UP1cEgSs-F6NFZm2a2QQbM4HXag@mail.gmail.com> (raw)
In-Reply-To: <aOLK-NyVsdwdWA82@neo>

On Mon, 6 Oct 2025, 04:46 Michael Niedermayer via ffmpeg-devel, <
ffmpeg-devel@ffmpeg.org> wrote:

> Hi
>
> On Thu, Oct 02, 2025 at 11:36:33PM +0200, David Dominguez via ffmpeg-devel
> wrote:
> > mpegts_write_pes() warns when DTS - PCR is negative. This is
> > done to detect frames that are late for decoding, meaning that
> > timestamping is wrong or the muxrate value is insufficient.
> >
> > But this comparison only makes sense on the first packet of
> > the frame. After that the comparison will always be negative
> > as DTS doesn't change until the next frame, resulting in
> > hundreds of useless warnings.
> >
> > Addtionaly, for long key frames that take several frame periods
> > to transmity false warnings may be issued if max_delay
> > is low enough. For example, in low latency CC video.
> >
> > Limiting the warning to the start of frame transmission fixes
> > these issues.
>
> This doesnt feel right, the time a frame is decoded has
> to be after all of its parts are transmitted


In TS, yes. This patch makes no sense.

Kieran

>
>
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

      reply	other threads:[~2025-10-06  5:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-10-02 21:36 [FFmpeg-devel] " David Dominguez via ffmpeg-devel
2025-10-05 19:46 ` [FFmpeg-devel] " Michael Niedermayer via ffmpeg-devel
2025-10-06  5:53   ` Kieran Kunhya via ffmpeg-devel [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CABGuwEkA76TYGKN-5OWqSK_UP1cEgSs-F6NFZm2a2QQbM4HXag@mail.gmail.com \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=kieran618@googlemail.com \
    --cc=michael@niedermayer.cc \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ http://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git