From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 751A94BADA for ; Sat, 27 Sep 2025 20:40:24 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'23gcE0a0Pbbw3kzJNy3wYS22O/TJQr5ImdpTLVGPGqs=', expected b'NAAlrv2TZ1xiZuQ3TenuOPLHJpiXK2VvOzjhc9ykpuo=')) header.d=proxyid.net header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759005613; h=mime-version : references : in-reply-to : date : message-id : to : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=23gcE0a0Pbbw3kzJNy3wYS22O/TJQr5ImdpTLVGPGqs=; b=xBs/YVVQMH+pC6yicaLcYIrpS53rdZXWXKn24vvjFq5mv+w9/2XpBXSeV75vfXB/O0zn0 wVk1AvNt9E9/MGHaNmH/bjPOpGBv7yZMhxNNxAlp0Vb7RDI58EauXjQFmgZTAfqoZhkigs5 fYiersIapzbhVqLHIMjXeDTNKzbt7cDYnQ+mBgzsmAWG+LjwS2Mcxk+8U0EH3Mwj69i8tGc NsxUF1bstHAfekowd/+gEJlgK8qEhjqIzwrXlgWn/lA3GvbVonybCS3Nq9Rca5OzShwVqO0 z5Xxuvwc20GkLE4gFwMwcYV6B1EVK7EfP7rxPMN+Dv/fbAXIzjeqsfLlWpgQ== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8B39568EBD2; Sat, 27 Sep 2025 23:40:13 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759005609; b=JJwvDpN1k2yOoa5tNW9ltMw6xHXrUpK83faChDfTIvGv7hpr0gE6yZT6LS+pt/wsX4wK9 U3/urIOSqy+3G0GJRZdihATslJo+Z7TB3IzuEVJ3Kqi+FtY6NnuH8SfJ36rb94jlG38q8gc X9Ts2yWOMwATzFt6n7WjQyPWo/yhpQhibR29WSkYlhy0lIntrzHxjnU09og0B0alvgyB+gJ jCldNe1Qn2ssAitMJA7vh82pgn0grhjC9+ydjUA2LWrumwflPtTSGOFv9HGzB4Fi1gDezbl 4akhjHatEnfSlrCf7EiAT7ZeBqBwqofWX6bMUPTLrg5L26pittDR3SerMVWQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759005609; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=23gcE0a0Pbbw3kzJNy3wYS22O/TJQr5ImdpTLVGPGqs=; b=maZU7uMOawuJTkviJBVdKobROpw9Sffpn5JyiysF/qa9gK2+CQf6ESHUk0WgYULQXW3Lf TuLvb0TGMJ1vTDqCvuWz9CHMSURIzV284atPGMGffQD1j6nG9OkW2AUN+iAuKhbeiJtyIUe +QN4gegfGi981bLqmyzX0B24esHkjaBqmcd5ksPMNaMcczVEWQ6TiTmoV9gkgrbAy+ZT9cG ezPEh9oYEV/ta0v2woU8t7SibLnSfrofMWiGY44Y+aC00rFkZY6PMImLQN5lZnQXQ8NxhJz mrzzu3Va7/tNqyGyE0vRW0Q6OWD6qcKsZJwipqTmKI/mS6QdFNapeJ80vxhw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=fail header.d=proxyid.net; arc=none; dmarc=none Authentication-Results: ffmpeg.org; dkim=fail header.d=proxyid.net; arc=none (Message is not ARC signed); dmarc=none Received: from mail-yw1-f171.google.com (mail-yw1-f171.google.com [209.85.128.171]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id EBD5F68E9F9 for ; Sat, 27 Sep 2025 23:39:55 +0300 (EEST) Received: by mail-yw1-f171.google.com with SMTP id 00721157ae682-73d47cbe2d7so1992757b3.3 for ; Sat, 27 Sep 2025 13:39:55 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=proxyid.net; s=google; t=1759005594; x=1759610394; darn=ffmpeg.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=NAAlrv2TZ1xiZuQ3TenuOPLHJpiXK2VvOzjhc9ykpuo=; b=XwPfZ+ddFVriMIZoPDvmw2x2go8UuwgWKUi0yhh8siuk2Oua0zkqGoxkmbmmyUUS1h acTqgR3lC3f8ma/OAc2lvndx1w+68dhFNNI+pNphBdiv6DUC+2vR7s9hxuTvH5v6DlbE c4kGBbZhJKhyJPzQNh4FOe3D27bPD116/uaq1dPa5xftp1TnhayZPaDX+2KtGlWZR25j MY0wS64Gc7r0adbKUCYLfMQs7U7CnNeeYEQ0iKBcl4EwdtSFyg3JEBjkk4CkOd0ZBM6x ZqjQiB1+n5jAdzVjPhFvzB3XqzckZo+5Dz2cqx8rkblh7I3HnwEAgxLshjWDvUmzyxJQ vNAQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759005594; x=1759610394; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=NAAlrv2TZ1xiZuQ3TenuOPLHJpiXK2VvOzjhc9ykpuo=; b=oOlNrBT2PQwRpg00WvEYJudvAS/H9PybEPsKsri8x9dPlg1/+y3m5m/yDaSCeeYHkb mwz8d/BcBA8aO3KnHrszDmx6eBRI7xrd6zhUHbFxrW7VE2EOSdodywWISGFsdNZIhzt+ Q5TrlQJdtnW888lX3FwMZG+iR3SBr37oM1SID1fCSIqiQPsr6WB/6NwqjRgp4zSjm+Py QfaY4JxpBF1TaX8TDv4QA9u0+7boGbMqcowuMpNKHimnCsOG+0MWauotsvyQjHNomVID q/so48uUneNdtpMieffqYpa8xj8CFk86yD5Kum4f73TKbBxMXrZI9z0nqfIXQAqD13Ec mA1A== X-Gm-Message-State: AOJu0YzxqiHQ5VquNfLnaa7t06bS49Jo9eZ07uDUlTxx0WZa3uqmzd3R K/biE/bCcduWcHQiG8+vqbtdQqVdLSxXDo7Uxe3B/20q9D6xJDWXhOkuabnwbvwEXxvj32KHqOQ nqtHd58J7gRz/4ulxAcjyHKntcf/zW5u0/hNG+Yuaug== X-Gm-Gg: ASbGncv1luB+L+zYqXlwQKpLjKx/xvXXt4grD0bzrdJ/yjLtAIvTvzz727QjXdfX/60 qfyyQtzZQlXVbR50LJ1yr3kzSiRxD8jVWw42kYj/2V+Lus//xI9znOLX7Cm9rxf4h+1I0nf3Dsn H29qbcZeY5t4ew7fxKjoWBGgfufKNg6KIMfVaO33zKTyIMMwS6CKZfcJoSs0cPZoDWqHqKdLnTS HpJvMz+rGATHvtwU8riki53HnplXPit7B1IUn+s4XOu1dsJFQ== X-Google-Smtp-Source: AGHT+IFiEUaVsELnjBr9oVNi93z5Dn6zRca0LW5mGyz8ix0GkU+QnX/CXDt/HwVoOGhdivl6eP0VhhI6n+PchQ5a8f0= X-Received: by 2002:a05:690e:151a:b0:615:7d8f:6951 with SMTP id 956f58d0204a3-6361a718359mr7579589d50.2.1759005594125; Sat, 27 Sep 2025 13:39:54 -0700 (PDT) MIME-Version: 1.0 References: <20250604165852.75087-1-romain.beauxis@gmail.com> <20250614225713.GP29660@pb2> <20250621215947.GY29660@pb2> <20250728002212.GX29660@pb2> <20250803213630.GI29660@pb2> <20250804001103.GR29660@pb2> <20250804082133.GS29660@pb2> In-Reply-To: Date: Sat, 27 Sep 2025 15:39:18 -0500 X-Gm-Features: AS18NWCOoB5gs46easxKI2R2IQlC1f9VxgvKV6gSFI3xHj2EneXQlpJ76F_sTus Message-ID: To: Romain Beauxis Message-ID-Hash: CQMBTBVJPXDW35P2427UTQZYZMVZM5ET X-Message-ID-Hash: CQMBTBVJPXDW35P2427UTQZYZMVZM5ET X-MailFrom: SRS0=ENgi=4G=proxyid.net=marth64@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams. List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Yalda via ffmpeg-devel Cc: FFmpeg development discussions and patches , Marvin Scholz , Lynne , Andreas Rheinhardt , Yalda Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: Hello, Apologies for the delay. I have been testing #20327 today with various samples (local, online) and the api-dump-stream-meta-test tool to observe metadata changes while listening. Code looks good, and to me it seems Romain addressed concerns. I think it makes sense to drop the header packets from output on segment change and store them as extradata. I do believe there might be a leak in the api-dump-stream-meta-test tool (but not in the demuxer change, which is this patch). Compare (valgrind reports errors): ``` valgrind --leak-check=full ./api-dump-stream-meta-test http://play.global.audio/city.ogg ``` vs. ffmpeg itself (clean) ``` valgrind --leak-check=full ./ffmpeg -i http://play.global.audio/city.ogg -c copy -f null - ``` I left a question in the PR, but no other concerns. Note I had found the above input stream from https://dir.xiph.org/codecs/Vorbis Thank you! Yalda _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org