From: Yalda via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>
To: Romain Beauxis <romain.beauxis@gmail.com>
Cc: FFmpeg development discussions and patches
<ffmpeg-devel@ffmpeg.org>, Marvin Scholz <epirat07@gmail.com>,
Lynne <dev@lynne.ee>,
Andreas Rheinhardt <andreas.rheinhardt@outlook.com>,
Yalda <marth64@proxyid.net>
Subject: [FFmpeg-devel] Re: [PATCH v2] ogg/vorbis: implement header packet skip in chained ogg bitstreams.
Date: Mon, 29 Sep 2025 11:46:06 -0500
Message-ID: <CAAhd_PVPprVWBCeKY8W5_z+kFek6E8G81mindUZo5xcRrJ9SUg@mail.gmail.com> (raw)
In-Reply-To: <CABWZ6OQ9YAPNZnJXeETuj5NHML-jRjJo7k+-yt8zQYHhaowsvA@mail.gmail.com>
Hi Romain,
My pleasure and thanks for contributing this change.
I was just wanting to know on this line (tagged in PR comments), if
there are scenarios
where we may only get one of these blocks on segment change and if we need to
also emit it to extradata.
```
if (priv->header && priv->comment && priv->setup) {
```
The answer may very well be no and that's fine.
Besides that I am willing to approve then merge after a short couple
days objections period.
The maintainer listed for this file is not active, so I'm not sure
there is anyone in particular we need to wait for.
_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org
next prev parent reply other threads:[~2025-09-29 16:47 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-04 16:58 [FFmpeg-devel] " Romain Beauxis
2025-06-10 18:04 ` Romain Beauxis
2025-06-12 11:35 ` Michael Niedermayer
2025-06-14 10:39 ` Romain Beauxis
2025-06-14 22:57 ` Michael Niedermayer
2025-06-21 8:45 ` Romain Beauxis
2025-06-21 21:59 ` Michael Niedermayer
2025-07-23 19:06 ` Romain Beauxis
2025-07-28 0:22 ` Michael Niedermayer
2025-07-28 21:12 ` Romain Beauxis
2025-08-03 21:36 ` Michael Niedermayer
2025-08-03 22:50 ` Romain Beauxis
2025-08-04 0:11 ` Michael Niedermayer
2025-08-04 0:19 ` Kieran Kunhya via ffmpeg-devel
2025-08-04 10:53 ` Nicolas George
2025-08-04 8:21 ` Michael Niedermayer
2025-08-04 15:59 ` Romain Beauxis
2025-08-11 22:31 ` Yalda
2025-08-12 0:21 ` Romain Beauxis
2025-08-12 0:23 ` Romain Beauxis
2025-08-12 16:33 ` Yalda
2025-08-12 16:38 ` Yalda
2025-08-12 19:49 ` Romain Beauxis
2025-08-13 13:44 ` Romain Beauxis
2025-08-13 13:46 ` Romain Beauxis
2025-08-20 20:24 ` Yalda via ffmpeg-devel
2025-08-24 15:28 ` Romain Beauxis via ffmpeg-devel
2025-09-27 20:39 ` [FFmpeg-devel] " Yalda via ffmpeg-devel
2025-09-29 15:24 ` Romain Beauxis via ffmpeg-devel
2025-09-29 16:46 ` Yalda via ffmpeg-devel [this message]
2025-09-29 17:51 ` Romain Beauxis via ffmpeg-devel
2025-09-29 18:24 ` Yalda via ffmpeg-devel
2025-10-01 14:21 ` Yalda via ffmpeg-devel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAAhd_PVPprVWBCeKY8W5_z+kFek6E8G81mindUZo5xcRrJ9SUg@mail.gmail.com \
--to=ffmpeg-devel@ffmpeg.org \
--cc=andreas.rheinhardt@outlook.com \
--cc=dev@lynne.ee \
--cc=epirat07@gmail.com \
--cc=marth64@proxyid.net \
--cc=romain.beauxis@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
This inbox may be cloned and mirrored by anyone:
git clone --mirror http://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 ffmpegdev ffmpegdev/ http://master.gitmailbox.com/ffmpegdev \
ffmpegdev@gitmailbox.com
public-inbox-index ffmpegdev
Example config snippet for mirrors.
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git