From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 52E4B4C0F5 for ; Wed, 8 Oct 2025 01:17:38 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'r7/ZPA98GLgsERIJ4bAmPfImFAlsPB6cyEI3HZp+bVQ=', expected b'YRMtu6pAffx9lnHEEfnPytdMCfbO/7vIqu61K4cSZLU=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759886239; h=mime-version : date : references : to : in-reply-to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=NcCXjtYUqFShTWlq6HNpQv6pGanL0gaorDROTxws9PI=; b=FgwRJ+6ABAhRFTmUGfisJ/SRodERzg6nrjldReOFF5/iVLvQ7o+fn/DxZ51qukHGjaxfE BdWGLPnoLId2PF8RLOV1IQcsUmaanqr7s2+OfW85NzTbzCZFwJTFPLE3z9ysBf+On+Ii9Ca Rm3rL/Ab9tlJOH3s02RxnUPkZq3Ok53QqoNbYYVB3olVisHVz2UFEETM/gpvTFwBRX2U0gd oYl0zHl4WfxvYs2AAPtkVhL2GH8vS7peRe9NFnb+U+t8jY27unLKdTrCIAPNWF/gkYnBE9U FfZl+Tj7dOz692XaH7666nyZgGxQ5QPoZFRAs/nj1O03oI4jhnxYNdpQisNw== Received: from [172.18.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id BB5E468F0CD; Wed, 8 Oct 2025 04:17:19 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759886222; b=f+G7h9w8BbCImdhOBDPPsdfxH57neMunDerYJeRWI/i3RLstUOI4AsQCWwLkYVmLBxEmU npKhCmqrG0Ujai7eJixM1oTx3si6Nn25fsMSRrBZ/jemJK5abkPTwjdW094eeEpRYRvowpF g5+kCTYUt/VqLHc9iCu1KZ9c0CPOvPTTv84fQ71j+NOuF3r9RAvv5sI0ndcrAC/KjBWySbt ItOqeuxZ3Tak3lWOqdvasDqeEhpJG0//3raocwZi1HyJRMqna5wQyH6JLPz/oMyrgsSNwJO qayBU8ZNaYRjTLUNDJ1f0C7uAzGFS6NZhVz5/qlQlxdqGr/fbAlR7ARztXPw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759886222; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=r7/ZPA98GLgsERIJ4bAmPfImFAlsPB6cyEI3HZp+bVQ=; b=pyv+B5ZL+MdTSHH8oF7WXFrNhqzl4eZkE9Xcu2ZsvjCjSdYA5n68FdQ4UAYBkA86Tjmqz 3rjZv0CVASmywmUFde5xchJulU8O6ZnLqBoVFyOxXlX0DJBoWRQPjYgwKYukN2CTQaVk+0f wzEYpMHQ7sGuNuzQf4+pNMa9UbceN9mH99R4s+DNdIitvAvI/7jKuOiJ4oIEp8xV9e5qnFN Vf3KzPPZQulJ27Q8fgfIdScG2xfUao9ga5QlFDG2ktDR1u8M86okMXw4fGxBwGWq6asYixg FWdwcWNLlG59XzETJWPc8JznpRsdA3SslkFI+o97MOR6ycSVy1z5eauwIqtg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pf1-f171.google.com (mail-pf1-f171.google.com [209.85.210.171]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 2712F68E8DF for ; Wed, 8 Oct 2025 04:16:50 +0300 (EEST) Received: by mail-pf1-f171.google.com with SMTP id d2e1a72fcca58-781010ff051so4865066b3a.0 for ; Tue, 07 Oct 2025 18:16:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759886208; x=1760491008; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=YRMtu6pAffx9lnHEEfnPytdMCfbO/7vIqu61K4cSZLU=; b=nPBPbaepLkykBsJK9ux8hD2he5fdskNtzUSGebiYXxIUR2h5t8BDR7fqcC00i2hgSZ GmrDPcRgv124arcLxIwr1v8B6vM6L1WBEVbSmtFeL0H48qDMfyHVavAp4zRv6tax8fIN Xa/S/q+Hr/R+zcrI0bDByYfruD4LV8pINboC5OpqlCVdTojWaDWeFqEAQLdwkMLiLZZU gW2k5+n2FeRKAb1B8ycMvv7rLPYrcOP9GDQ3yx/Z4nO1PPO7CGE1/pmKAwlXAWqpKfn3 VlDpcBD5qbK7JSJhxxkgUALwx+r82GqBb+pJNwg04hwcXT6SIRL7DulzfD871k+uGOjX 8LMA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759886208; x=1760491008; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=YRMtu6pAffx9lnHEEfnPytdMCfbO/7vIqu61K4cSZLU=; b=mNbFj6zpKXPkbXpQwLfDCzlN+xIdtD6uz8KQ/exmX5e3qyTUTjXlGwIDdP0kFDaAAa deLVQd6tNa4qdCcZNtO/qw2BGWRlcN8nlNfNnwsPZl8tKPNEphWuSaD86Eod49rE0o/U Dp3lrpHZ2g6ec+g5I3gGi+5mlC9c/SRxW86mR9OY/5NXsy8Op1sew7hTOk7IoMmVL+Y3 tzfCWCQT3aKXbeFEdq9smLgZVpxbdCdZYWKpj5iUH9BM9Ia9LZxeA4ii3vuUW71/E82n jLChbv9TfxgGQTrC0hwHYwhGy4JBy5zOORwa7Z1Ywgig+hl37OIssi/SwpUi5u+l8HWE v2DA== X-Gm-Message-State: AOJu0YzZ6n0iWvg9q1EXqvMHawQoyM7p6Z1srWDdQC1isSaNG780k9ov B67Z3ZR4vlLgfYiAT7NDnWgcD2JzP0vto9NYKHnyp1bWOUFeMiwpJ7pSQAot91Ov X-Gm-Gg: ASbGncuzBxXW6F/4cEZ9eI6TRi59WhHeyykKWPPtjoFcSvNa3DXVXoXktshDo/ep6nK SFeavcqp6vYKbFpWNmROmOUKksS8q6MgOHZfJiO1kNM3Eug/yjt4yhp0Ro9gek+KgIdgx1/Ijcx uQg3LSHYAK5IEFZ60q4uSdzD3zpr1rK6Dkm3nUDxK+PeKJQzR6ZHdMFovMyIYcnuKtPp/uoGhIg /X+9Mpsmhg1wXlpyS7Erx18usWYgVgLg+BRovZNG0uN6r7ZGPqyw878jM7O/SkWNjNqqzZGfcSO aArV8tIiFNCNcchpy9V1clB/Bry0LFjrJaDy9vsspqX4sDNMpGyCmaG7kwPBgcnpgx2TdRY8KtX k5daLqlgrzDg4EpZmkYpJCraRHRyBPZb9KN8S/3j9tHdtr+FhcToAda9gEY0= X-Google-Smtp-Source: AGHT+IGhObAY98bdK+ynhgaKHnHkoEIesiA/0+U00I4slrltkTwoj/QnX9VV1ko6Tmm5EuGD6J51rQ== X-Received: by 2002:a05:6a20:7f91:b0:32b:727f:5fbb with SMTP id adf61e73a8af0-32da812de08mr2152678637.20.1759886207669; Tue, 07 Oct 2025 18:16:47 -0700 (PDT) Received: from smtpclient.apple ([23.247.137.216]) by smtp.gmail.com with ESMTPSA id 41be03b00d2f7-b6099f729c3sm16453030a12.46.2025.10.07.18.16.46 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 07 Oct 2025 18:16:47 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Date: Wed, 8 Oct 2025 09:16:33 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: Message-Id: X-Mailer: Apple Mail (2.3826.700.81) Message-ID-Hash: 6FJWZFLPDGL2XZLOCPXCLI55TI5BUO6T X-Message-ID-Hash: 6FJWZFLPDGL2XZLOCPXCLI55TI5BUO6T X-MailFrom: SRS0=Di39=4R=gmail.com=jacklau1222gm@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avformat/whip: Drop invalid group:BUNDLE from SDP in single-stream cases List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jack Lau via ffmpeg-devel Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: > On Oct 6, 2025, at 16:06, baigao via ffmpeg-devel wrote: > > --- > libavformat/whip.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 472c6dbf16..6ace9240f9 100644 > --- a/libavformat/whip.c > +++ b/libavformat/whip.c > @@ -617,12 +617,14 @@ static int generate_sdp_offer(AVFormatContext *s) > "o=FFmpeg %s 2 IN IP4 %s\r\n" > "s=FFmpegPublishSession\r\n" > "t=0 0\r\n" > - "a=group:BUNDLE 0 1\r\n" > "a=extmap-allow-mixed\r\n" > "a=msid-semantic: WMS\r\n", > WHIP_SDP_SESSION_ID, > WHIP_SDP_CREATOR_IP); > > + if (whip->audio_par && whip->video_par) > + av_bprintf(&bp, "a=group:BUNDLE 0 1\r\n"); > + After testing this patch, I found something need to be improved The bug cause by the a=group:BUNDLE use non-exist mid when there is single stream Some SFUs reject non-bundle SDP(like SRS), and Chrome generate SDP with BUNDLE even though there is single stream. So, to improve compatibility, please consider making such change diff --git a/libavformat/whip.c b/libavformat/whip.c index 6ace9240f9..5b9520041b 100644 --- a/libavformat/whip.c +++ b/libavformat/whip.c @@ -622,8 +622,12 @@ static int generate_sdp_offer(AVFormatContext *s) WHIP_SDP_SESSION_ID, WHIP_SDP_CREATOR_IP); - if (whip->audio_par && whip->video_par) - av_bprintf(&bp, "a=group:BUNDLE 0 1\r\n"); + av_bprintf(&bp, "a=group:BUNDLE"); + if (whip->audio_par) + av_bprintf(&bp, " 0"); + if(whip->video_par) + av_bprintf(&bp, " 1"); + av_bprintf(&bp, "\r\n"); if (whip->audio_par) { if (whip->audio_par->codec_id == AV_CODEC_ID_OPUS) > if (whip->audio_par) { > if (whip->audio_par->codec_id == AV_CODEC_ID_OPUS) > acodec_name = "opus"; > -- > 2.51.0 > > _______________________________________________ > ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org > To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org Thanks Jack _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org