From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.mplayerhq.hu (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTP id E624742054 for ; Sat, 15 Jan 2022 06:40:31 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTP id 1271A68B3F5; Sat, 15 Jan 2022 08:40:29 +0200 (EET) Received: from EUR05-DB8-obe.outbound.protection.outlook.com (mail-db8eur05olkn2095.outbound.protection.outlook.com [40.92.89.95]) by ffbox0-bg.mplayerhq.hu (Postfix) with ESMTPS id AD42668B36D for ; Sat, 15 Jan 2022 08:40:22 +0200 (EET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=VeLuJt93Gsa/lD1YwJbgNA2ZZ0VkkV1r4nC9T3lpvr0/lxnlVSLoZKprToHX2Kgeen3uGIOgReAHicF++lGhUfFfGqaWnvvB7YiFhGgfjQkg5hkM4h1AU15xd2JI+KOGpAlUe0vBg4kfWZSvuJhKoIxyahY2ZGchJDgsGrjRIzLKVvaI9onn3qPGHlDhAEbL24lo1R6MY27jzZJnvB/F1dHboOFq94yHj5qBZzzLjjLmT7XKqgxXbQnX9W7JdXD3NjBzK9hcnb4ldQ/Cc+Efo0vB3/P7I9k/FwobZW2Hwf6VXo0FMqVx2aZ7b19So96LZGgrGoRNPTqYeRPoKCKFLw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=zNhkdZTwKXa6VbSxctpN6S3C0OZS0SNoUj093fLiSZI=; b=Pn8oL3Pl3hGycAHy/wUqk0OmI3iGJxvdpdxY7CPihT/FDgZKFHtfcijCe0PDmdPsVjkoVHYQCXSfsMXO9DlOb9ibI5Z1Uxb4KcEbodykrErflr6nJ00P91T8mBmNpYaiuVArmzvjHO8Q4KGo4n+hawu2p67esSldoW4byLUFHcp18JW+xgVY2vCDhmbfIDAgF/1Yz81MkZ+cTMp4tGSX2mNL3ga1C5wTRB43lS+1aQO8acBPmRMRe+AWNQ+pC+ru8NgH9TH8WuSXBGfPFPtCNjXLV5o58/CS/x9JHlIOHTJj9JiCssxTfuh8E0MyUJFFhg/1X39LSxDAW45+c9iUiQ== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=none; dmarc=none; dkim=none; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=outlook.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=zNhkdZTwKXa6VbSxctpN6S3C0OZS0SNoUj093fLiSZI=; b=mh1yWt8it7WO8ZM2E66CkUGZF0VllECL6/YOUkDBLhaz6zRJlHTH7OtroIkxU2Kt25f+GOBNJAdiDzI3lKMt7iy58RPau4maCR8pB9/Knt1yjAF0PZVhRPEXLEJTbhNNJygZorjO7wFJBN2H0LtFB7y8D7bPTJn3RycW6HNqDVGoxE/NE26jNYnkgVJIz+NaYsfjCVj3bvujzzHI3LpFEPipoKuAqvHR2wCw5mI9pRdELhaai8TLcEfDu5AEH0BWmWQhdDIzQHWM3AI3iPFEdv0N1a2wbwhPNst2jfaFRgrYtejy+S7sNpxsTzYMN9n7u5Ekj7BUI3YWAkgS9aWybg== Received: from AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) by DB6PR03MB2934.eurprd03.prod.outlook.com (2603:10a6:6:36::29) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4867.11; Sat, 15 Jan 2022 06:40:20 +0000 Received: from AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5]) by AM7PR03MB6660.eurprd03.prod.outlook.com ([fe80::19fc:be9f:2c9c:53f5%9]) with mapi id 15.20.4888.012; Sat, 15 Jan 2022 06:40:20 +0000 Message-ID: Date: Sat, 15 Jan 2022 07:40:18 +0100 Content-Language: en-US To: ffmpeg-devel@ffmpeg.org References: From: Andreas Rheinhardt In-Reply-To: X-TMN: [yPR4+7JoA3l8sl+3tK/mtyfZJbpy8et6] X-ClientProxiedBy: AS9PR0301CA0008.eurprd03.prod.outlook.com (2603:10a6:20b:468::17) To AM7PR03MB6660.eurprd03.prod.outlook.com (2603:10a6:20b:1c1::22) X-Microsoft-Original-Message-ID: MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 7c3c20ee-a8a9-427a-e163-08d9d7f1e639 X-MS-TrafficTypeDiagnostic: DB6PR03MB2934:EE_ X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: GwsFy9vcNwVzloSCpPGOR3nNWTFSksmfAGS4P5aSANV0mdBF2EshrOkohw9ZizVSB23AzVzJ0W5FlExN/2oEizelO2JmrSZUYE+lZFCYrOVqlaQ29y9u7G7490Mz4Gv/Q/HPTiLLYxp8rcpvOQGMmQagPO9F90EX3AOuDkUVn0sg8/wBO45GR/KbePOLwguKgrQK2RiCn5kAgSm9i70tSNimQ7UFNKPcuXFCsFuaa60gjrCaHO0NIurXiBqNuW4ZRqTWLes51MnfITiQ9WyHj1XBG88eQFzlU/m1zUnVkqd73MLjOxXQ+NbhunHr2mjdHPfMQiK6deSKP/fXUpQz4UtIi9yqB1tAAxpfVZX7kL1f7P66hSoZRHCDAe/ZRZz0TcosJ38eDyPfsqKtDqyqGA6FHay2Tj/4U728AJPANnWKwWdM/j397hsvzeU2cIqBKqrT/Podl5pt9xmDGG0xxCMNcrnwOc9XPX/mopWx9Wm+jqENsOtCaUGPcrh85Xz2Efkv9mHQUz6vgRJo6sXuOcnMb/CkYSPGROCby/cBkFhXGRYgQVcBWh7a7EKqrkk+tCyPCvdvWM2KlkJZ3wGVsDUJ1JZptgjexaOIGxIZ2XGnPG9+KmhM/YCpIo0yRC1iobzlWqfr2QlZv79M7YUFbtiWjxz0jkPgUdfQEBcdWng= X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Tkp6NVg3MlZmWGpYanhNc3BVdHo1N0RRMUE5UHRBYjFVOXByUkVoMjVmSDZO?= =?utf-8?B?T2kwTEw3TnBlVCt0OU04TE1NOERLRTFoeWVZTWVaVWpzZ1c5L2VRcklyemsz?= =?utf-8?B?RWFKNWFmTDh2UnhlbiswU3hQbnV1RW9WV3R2akdRbUhJUnB4TWxXS1lPQldJ?= =?utf-8?B?VlpTeW5VNkd4am4rQTU3ZVYwUnVkclRsTzFjR0h5ZUxsUVBlMUR5TFlsVWw3?= =?utf-8?B?NFl6UDgydWxGeW9hWkZsQ1RDcFI4L2tNb0VZeGI4bGxETnIzZFZyOE9od2Q1?= =?utf-8?B?VkNNaFFaMjRwNFpBMDQwSUF3dGxRUHlkRXJ2RnhUcDNlakJzWHpBclRoSnJX?= =?utf-8?B?ZkROS0tyRnBJRWVsVklmVmxUL2g2QjhTaXlpajJydGhjVXluWW1ya2tyM2F4?= =?utf-8?B?YVloZm1kNm9NK2ZLMzRyNHNRZmFDZE1BWVJjZktFMTEvSmZjTE5BckxzU01Q?= =?utf-8?B?QVFlb3kvbmczdzZCVy9pNjBONkRDdHpRMlZTRDhBSy9sSFJQOHhjOVYrdUZY?= =?utf-8?B?cHFmaGplY25Sd0lZRUNpL0xoMG91NzNLblM5dStyLys3ZXZaRktzUWVNaXdp?= =?utf-8?B?R2IvMVBHekJIczNycXhmWURHZkdJMkdTV2JLeURhemYyWEpDQk1YZWRiOHpu?= =?utf-8?B?OE1OS3pOcTRMSkRyZ1kxeVBrZ1Z1V2NBRkJuell3RVd5ZExhWjYrKy9xYzly?= =?utf-8?B?VFNEL2N2NXl4cjZBcEN2amNpL2ZvQmxZcWVhMGplY05jSmt0SStxU2pnckFS?= =?utf-8?B?bXl1RVBGdjlmRjlZajc0TCtiajBlRkVQMWhBczRKcUxkcW9BTWVobW9qTDJD?= =?utf-8?B?MGxWNXhUdXhmUmc0TGtCWmExTk10M0Z4b3MzUldQaHIvSWFDZE0rdlpNK0xM?= =?utf-8?B?QzNRbXpxQXFpL3puYUJBOFQ4QjcxMUZnQ21TMmRHTGpTVzFVT1lWZ0ZzWnlU?= =?utf-8?B?eTdaVzZYekhhZE9vMmFVOGVBMHZIQm84UnBjSkU3d3pVSXltNjdFMFhxOXpF?= =?utf-8?B?RDNSSTJjMUVwQmZqakdEdmtUNjc1cCsvOGF0bVJHMk9oczZST3c1S1puRUgz?= =?utf-8?B?ZHlwSjg0eGpCeWZ5bk9xZ3pNMTdYSGs5Q2t6Zm9scXlGdW1zTW13b3hPU0lC?= =?utf-8?B?VXEyUWdsd3ZSZi9BWFFmVHhrQmtTOTlqYUV3ZTFVOWVENUc4SHFvQUZQdThv?= =?utf-8?B?cElIV3BJT2tyWjNCeTNnaUFzcmUyTTlxOWdoV0FQckFENHZiZFV3cWtrZmo1?= =?utf-8?B?RVlsWkxMdVl2UWtFQ3Baa0x3cnlQZFJ5d2ZwNklaUk1SNzhldz09?= X-OriginatorOrg: outlook.com X-MS-Exchange-CrossTenant-Network-Message-Id: 7c3c20ee-a8a9-427a-e163-08d9d7f1e639 X-MS-Exchange-CrossTenant-AuthSource: AM7PR03MB6660.eurprd03.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Jan 2022 06:40:20.3353 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 84df9e7f-e9f6-40af-b435-aaaaaaaaaaaa X-MS-Exchange-CrossTenant-RMS-PersistedConsumerOrg: 00000000-0000-0000-0000-000000000000 X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR03MB2934 Subject: Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Fix path handling on Windows X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: FFmpeg development discussions and patches Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: ffmpegagent: > From: softworkz > > Signed-off-by: softworkz > --- > avformat/hlsenc: Fix path handling on Windows > > Handling for DOS path separators was missing > > Published-As: https://github.com/ffstaging/FFmpeg/releases/tag/pr-ffstaging-19%2Fsoftworkz%2Fsubmit_hlspath-v1 > Fetch-It-Via: git fetch https://github.com/ffstaging/FFmpeg pr-ffstaging-19/softworkz/submit_hlspath-v1 > Pull-Request: https://github.com/ffstaging/FFmpeg/pull/19 > > libavformat/hlsenc.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index ef8973cea1..eff7f4212e 100644 > --- a/libavformat/hlsenc.c > +++ b/libavformat/hlsenc.c > @@ -3028,6 +3028,10 @@ static int hls_init(AVFormatContext *s) > } > > p = strrchr(vs->m3u8_name, '/'); > +#if HAVE_DOS_PATHS > + p = FFMAX(p, strrchr(vs->m3u8_name, '\\')); > +#endif > + > if (p) { > char tmp = *(++p); > *p = '\0'; > > base-commit: c936c319bd54f097cc1d75b1ee1c407d53215d71 > 1. You seem to be under the impression that NULL <= all other pointers. This is wrong. Relational operators acting on pointers are only defined when both point to the same object (the case of "one past the last element of an array" is also allowed) and are undefined behaviour otherwise. 2. Apart from that: Your code would potentially evaluate strrchr() multiple times which is bad style (given that this function is likely marked as pure the compiler could probably optimize the second call away, but this is not a given). 3. The code in av_basename() is also wrong. 4. Is there actually a reason why you don't use av_basename() directly here? - Andreas _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe".