From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 1685C4BFDE for ; Mon, 6 Oct 2025 11:34:04 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'D09/iagNIzz37U4T1DONBmYFdzK0L4RngkxkYCWccXs=', expected b'myWtv4B7U3XxfoeLhsaoKix7o6ge+xsgBeypnEbhgbM=')) header.d=gmail.com header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759750437; h=mime-version : date : references : to : in-reply-to : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=ytG0p1RUidpKizQsdTMeccypdbvr88YmoJR5hr7489c=; b=FX7OEn+U4SPED6VaLujTqdeY5WqH4gOJnwOMLw2JNbTL7LWv6SDlvnk+LioHvjIh/ia5P 8zxFl+ma+kaaTlKoj3Nk8TfYbGjKetfFWOnIwsUQQUnIKzteaKNyfFGZ7gMaWqiORLUkqCj XVmAri+x6aOItEC+OqK2WkAZ2OdVvTVbgc0O4wqakYubsNg2jK/lNeyoz/GxDFgOs7qTkta JZKUP8TIvcJxN8IWzhiN3rtR8FjCQSpdjtCkNPEoM1gmgPLsdLQvFGj0CRie5pQwgotn+iv IAKk6SWGrgT5Nsbq0Fg6Z2BWZq1u9edRC3txfF5qxIqVGTc74DiWCq6OfSzQ== Received: from [172.18.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 3EF1A68EFE3; Mon, 6 Oct 2025 14:33:57 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759750424; b=midx/wrYvOnOFz+AxQU8TB28UVGiQekEpwafqOlx13jHaJEnRVV6J30qDMc+Xi1pFaGqO zKdfGEdNGFIdDJHt0qEPtB+3ub8P238hn3h7/IwIMTICd0ZZhzjcTlq5XRYHcpSuC6tHdWl h9vID69qpxNn/1fCy/ZwdFAgLtK3N8f/lhXW0ud/8ctZs1SGv3vo43Mxc6lY9n5nWy/4aiy o5QkrSIgA9J4A/vqzSYi4OkOQmjPhe/hS2oXH77WE3XfvVVbrKpGbbVxe4HrZra8jLEUKK7 ql6LxmifIGuh1BQFOY45Ql+WwtLs4C/HgMRUZI42OnSXfnwSSaCyrURfYr7Q== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759750424; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=D09/iagNIzz37U4T1DONBmYFdzK0L4RngkxkYCWccXs=; b=oiniU5cS0X/QzS/egSu4U+DHWX09F6sDpAQnCST7rXDtBN7vPvflGMkoJFVqFfj4xFjXj z2x1aqNc6loig+5ldDsO5Ecw0LrVqFnUoUON2qngduWHw7l6r1Ak4QCg7uJdBCjKO8+aLI8 tBHCDPd0/ylApoPYbSv6gX3WZPglKo4s+Uv5gPA5FLhr15/0CrjrRoNC6bwVsytF4Qqo8Vq gdh9nLILUIl4pCtWuEOGwmOHs2mretdmZsPAnG8XIzt4Iby/poyMLsyUHxePHGN208iYp4p sC5y8faV74UiROvJ4NaCV3lClzRhpgkX4PBo5ykYENPXGrGwBcgA2ZTsNZTA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=gmail.com; arc=none; dmarc=pass header.from=gmail.com policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=gmail.com; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=gmail.com policy.dmarc=quarantine Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 469CA68CCBB for ; Mon, 6 Oct 2025 14:33:33 +0300 (EEST) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-339d53f4960so1793806a91.3 for ; Mon, 06 Oct 2025 04:33:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1759750411; x=1760355211; darn=ffmpeg.org; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=myWtv4B7U3XxfoeLhsaoKix7o6ge+xsgBeypnEbhgbM=; b=g1cLz+6RL2hX0YgtpJ2GqxT5qVX6B/3Oud4A8aItbokQ2N9BFoDbWXXEMaUJR/pA66 JFEGw2IHXAMCjyzOGORW+d1SvgY0DTVPaQ8bfOANPAslLOvoL4Ib0TX4unbzNuDoxYSp 6pNoLFyzHluJPJg7rzgM8Eiw3xHd7vwSzR7meyv9Afi0V59YQV+/71k5VBTRNsguT0/g 2Q4sq3ufUgBO+L5ID9JGcSl5nOx7W4ke58dRfcLsB/lrfNAnnGBLXxhopYr8kI1N0CQe kx3gB9FJyo+gidwHbHWPyK7qP8AhoaWKddp8FCWGjceW/lCMR7o+BAI73vNN44QaBPPh HgOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1759750411; x=1760355211; h=message-id:in-reply-to:to:references:date:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=myWtv4B7U3XxfoeLhsaoKix7o6ge+xsgBeypnEbhgbM=; b=Og6hFPWLB4mFgfc+qVIMDk8Rw5O0pY/wWPLtxjEJKPsBPkLKLOSAGNCzA/kMHaDePU oQ4zNAh6mnuRMNNopNkHLg20pjgIh98CAVO/dz2PJDB4tuE7z67Alk5KSXEZuIUVP5EA zQDxZaQiDzYTiT9MU6wwhkS9L3euuZet1FEE1vuNMl9ssafvOeMwfqqaHEMMl9oEn8Sy hPS7XaY6IV1X/wIIBeBdYM0E1O+BBBuEEvD3rLuM8TJVgtMOVd1l748MMjdMTzKZO7B9 bqMVV0ubRgx/N4SQM5Q37yXz+m3vYhmZkdkwdaQsWFwa3+GdUlw4qMbFSKb66dNlrMwo U8Og== X-Gm-Message-State: AOJu0YwIY4OeMqTSKLBoUSVflMvmh4ofl2zKgMX5mU0QHv05GwCMNNLz HEhfBrg6mX6IW2OTm6kHP1KX2ynmi5J4915rovXbR8lnufCjw1T7FNGqUSMX4WCq X-Gm-Gg: ASbGnctWKtrepk+y54Mrgn1LVnUQ6skaF0ujv4pOz+gD0kVkjz3qSmFPkZKL6v/f99t CNkMexB4Djv8+hQOqMG5BAQ3Qz6kOptGaoozeWr6JEE8coX05dR74F9MO6u6e0EFHPt0p2OeCv/ E62OfesAQogDeE6ZThRtGkk9aL2brTCVZjRn9sXdYHaJp3ksRcWE/aHPbYAU54YQDVN/N3Ww2zF Bj5LjnWxXjNCDb3pCGJTYjWBQHcYm2pW5l4gzfmA5Tsf+0qx1obVCo+/YMgeXxHETXJPFPe0nes +CW03NOtPhVKFdc3G5If6PUICGtgLCes5zy0/+g/cPeeUpp+nfpnL4E3N7TC1CRZunT50TgqHEo 7OvssqfQOM9PxgI4d2LApVolfoN1FmLt+smEKlaGyWy4i5CXDsOwxmEqXb1cnQok2vnOYcg== X-Google-Smtp-Source: AGHT+IGmqekEDkJSI1OTGI/gJHt4AxWcS/l0btzpN3jAgAxxQAVbYBXjlhjHKMkk0IrPYn678osmqA== X-Received: by 2002:a17:90b:4a11:b0:32e:e18a:3691 with SMTP id 98e67ed59e1d1-339c27b3cf0mr14467356a91.35.1759750410381; Mon, 06 Oct 2025 04:33:30 -0700 (PDT) Received: from smtpclient.apple ([23.247.137.216]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-78b01fb1b73sm12410432b3a.28.2025.10.06.04.33.29 for (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Oct 2025 04:33:30 -0700 (PDT) Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3826.700.81\)) Date: Mon, 6 Oct 2025 19:33:16 +0800 References: To: FFmpeg development discussions and patches In-Reply-To: Message-Id: <4EBADFE0-04EF-4DA8-8DB5-C5A48F443CE7@gmail.com> X-Mailer: Apple Mail (2.3826.700.81) Message-ID-Hash: G2YGNL2GKRGAOJIFDC2BX5OJJLZCGNRK X-Message-ID-Hash: G2YGNL2GKRGAOJIFDC2BX5OJJLZCGNRK X-MailFrom: SRS0=hpc/=4P=gmail.com=jacklau1222gm@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] Re: [PATCH] avformat/whip: Drop invalid group:BUNDLE from SDP in single-stream cases List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Jack Lau via ffmpeg-devel Cc: Jack Lau Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: > On Oct 6, 2025, at 16:06, baigao via ffmpeg-devel wrote: > > --- > libavformat/whip.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/whip.c b/libavformat/whip.c > index 472c6dbf16..6ace9240f9 100644 > --- a/libavformat/whip.c > +++ b/libavformat/whip.c > @@ -617,12 +617,14 @@ static int generate_sdp_offer(AVFormatContext *s) > "o=FFmpeg %s 2 IN IP4 %s\r\n" > "s=FFmpegPublishSession\r\n" > "t=0 0\r\n" > - "a=group:BUNDLE 0 1\r\n" > "a=extmap-allow-mixed\r\n" > "a=msid-semantic: WMS\r\n", > WHIP_SDP_SESSION_ID, > WHIP_SDP_CREATOR_IP); > > + if (whip->audio_par && whip->video_par) > + av_bprintf(&bp, "a=group:BUNDLE 0 1\r\n"); > + > if (whip->audio_par) { > if (whip->audio_par->codec_id == AV_CODEC_ID_OPUS) > acodec_name = "opus"; > -- > 2.51.0 > > _______________________________________________ > ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org > To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org LGTM Thanks! _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org