From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id C724A40025 for ; Sat, 16 Aug 2025 16:45:48 +0000 (UTC) Received: from [127.0.1.1] (localhost [127.0.0.1]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 8BCC868CD29; Sat, 16 Aug 2025 19:45:44 +0300 (EEST) Received: from relay7-d.mail.gandi.net (relay7-d.mail.gandi.net [217.70.183.200]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 86AE368BC2E for ; Sat, 16 Aug 2025 19:45:37 +0300 (EEST) Received: by mail.gandi.net (Postfix) with ESMTPSA id DA240439A0 for ; Sat, 16 Aug 2025 16:45:36 +0000 (UTC) Date: Sat, 16 Aug 2025 18:45:35 +0200 To: FFmpeg development discussions and patches Message-ID: <20250816164535.GS29660@pb2> References: <20250609122551.1373509-1-michael@niedermayer.cc> <20250613204646.GG29660@pb2> <20250614204742.GK29660@pb2> MIME-Version: 1.0 In-Reply-To: X-GND-State: clean X-GND-Score: -85 X-GND-Cause: gggruggvucftvghtrhhoucdtuddrgeeffedrtdefgddugeejfeeiucetufdoteggodetrfdotffvucfrrhhofhhilhgvmecuifetpfffkfdpucggtfgfnhhsuhgsshgtrhhisggvnecuuegrihhlohhuthemuceftddunecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenfghrlhcuvffnffculdduhedmnecujfgurhepfffhvffukfhfgggtuggjsehgtderredttdejnecuhfhrohhmpefoihgthhgrvghlucfpihgvuggvrhhmrgihvghruceomhhitghhrggvlhesnhhivgguvghrmhgrhigvrhdrtggtqeenucggtffrrghtthgvrhhnpeelkeeggfffiedufeejueffjeduhedttdduledtheevveevtdeiueelhfdtuedtkeenucfkphepgedurdeiiedrieehrddujeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehinhgvthepgedurdeiiedrieehrddujeeipdhhvghloheplhhotggrlhhhohhsthdpmhgrihhlfhhrohhmpehmihgthhgrvghlsehnihgvuggvrhhmrgihvghrrdgttgdpnhgspghrtghpthhtohepuddprhgtphhtthhopehffhhmphgvghdquggvvhgvlhesfhhfmhhpvghgrdhorhhg X-GND-Sasl: michael@niedermayer.cc Subject: Re: [FFmpeg-devel] [PATCH] Revert "avformat/mpegts: update stream info when PMT ES stream_type changes" X-BeenThere: ffmpeg-devel@ffmpeg.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: FFmpeg development discussions and patches List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Michael Niedermayer via ffmpeg-devel Reply-To: FFmpeg development discussions and patches Cc: Michael Niedermayer Content-Type: multipart/mixed; boundary="===============7866360842234948260==" Errors-To: ffmpeg-devel-bounces@ffmpeg.org Sender: "ffmpeg-devel" Archived-At: List-Archive: List-Post: --===============7866360842234948260== Content-Type: multipart/signed; micalg=pgp-sha512; protocol="application/pgp-signature"; boundary="2zf80yvl5vv3Xl3h" Content-Disposition: inline --2zf80yvl5vv3Xl3h Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable HI Kacper On Wed, Aug 13, 2025 at 02:42:13AM +0200, Kacper Michajlow wrote: > On Sat, 14 Jun 2025 at 22:47, Michael Niedermayer > wrote: > > > > On Fri, Jun 13, 2025 at 04:06:31PM -0600, Pavel Koshevoy wrote: > > > On Fri, Jun 13, 2025 at 2:46=E2=80=AFPM Michael Niedermayer > > > wrote: > > > > > > > On Mon, Jun 09, 2025 at 02:25:51PM +0200, Michael Niedermayer wrote: > > > > > This fixes mixing up contexts, use of uninitialized data and cras= hes. > > > > > More specifically: > > > > > > > > > > =3D=3D1001752=3D=3D Conditional jump or move depends on uninitial= ised value(s) > > > > > =3D=3D1001752=3D=3D at 0xA9ED82: avpriv_h264_has_num_reorder_f= rames > > > > (h264dec.c:64) > > > > > =3D=3D1001752=3D=3D by 0x668C7E: has_decode_delay_been_guessed= (demux.c:757) > > > > > =3D=3D1001752=3D=3D by 0x66AB13: compute_pkt_fields (demux.c:1= 137) > > > > > =3D=3D1001752=3D=3D by 0x66B2E9: parse_packet (demux.c:1265) > > > > > =3D=3D1001752=3D=3D by 0x66BD84: read_frame_internal (demux.c:= 1449) > > > > > =3D=3D1001752=3D=3D by 0x67085B: avformat_find_stream_info (de= mux.c:2692) > > > > > =3D=3D1001752=3D=3D by 0x25157C: ifile_open (ffmpeg_demux.c:18= 14) > > > > > =3D=3D1001752=3D=3D by 0x272B15: open_files (ffmpeg_opt.c:1366) > > > > > =3D=3D1001752=3D=3D by 0x272D85: ffmpeg_parse_options (ffmpeg_= opt.c:1415) > > > > > =3D=3D1001752=3D=3D by 0x2925C9: main (ffmpeg.c:991) > > > > > =3D=3D1001752=3D=3D Uninitialised value was created by a heap al= location > > > > > =3D=3D1001752=3D=3D at 0x483E0F0: memalign (in > > > > /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.s= o) > > > > > =3D=3D1001752=3D=3D by 0x483E212: posix_memalign (in > > > > /usr/lib/x86_64-linux-gnu/valgrind/vgpreload_memcheck-amd64-linux.s= o) > > > > > =3D=3D1001752=3D=3D by 0x14882CE: av_malloc (mem.c:107) > > > > > =3D=3D1001752=3D=3D by 0x1463785: av_buffer_alloc (buffer.c:82) > > > > > =3D=3D1001752=3D=3D by 0x146423F: pool_alloc_buffer (buffer.c:= 369) > > > > > =3D=3D1001752=3D=3D by 0x14643C4: av_buffer_pool_get (buffer.c= :407) > > > > > =3D=3D1001752=3D=3D by 0x752C4B: buffer_pool_get (mpegts.c:114= 2) > > > > > =3D=3D1001752=3D=3D by 0x7538F2: mpegts_push_data (mpegts.c:14= 07) > > > > > =3D=3D1001752=3D=3D by 0x758893: handle_packet (mpegts.c:2909) > > > > > =3D=3D1001752=3D=3D by 0x758E90: handle_packets (mpegts.c:3048) > > > > > =3D=3D1001752=3D=3D by 0x759B1D: mpegts_read_packet (mpegts.c:= 3290) > > > > > =3D=3D1001752=3D=3D by 0x6687A3: ff_read_packet (demux.c:649) > > > > > =3D=3D1001752=3D=3D by 0x66B594: read_frame_internal (demux.c:= 1346) > > > > > =3D=3D1001752=3D=3D by 0x67085B: avformat_find_stream_info (de= mux.c:2692) > > > > > =3D=3D1001752=3D=3D by 0x25157C: ifile_open (ffmpeg_demux.c:18= 14) > > > > > =3D=3D1001752=3D=3D by 0x272B15: open_files (ffmpeg_opt.c:1366) > > > > > =3D=3D1001752=3D=3D by 0x272D85: ffmpeg_parse_options (ffmpeg_= opt.c:1415) > > > > > =3D=3D1001752=3D=3D by 0x2925C9: main (ffmpeg.c:991) > > > > > > > > > > Found-by: Alexander A. Shvedov > > > > > CC: Pavel Koshevoy > > > > > This reverts commit 0021484d05f9b0f032fa319399de6e24eea0c04f. > > > > > --- > > > > > libavformat/mpegts.c | 4 +--- > > > > > tests/ref/fate/ts-demux | 4 ++-- > > > > > 2 files changed, 3 insertions(+), 5 deletions(-) > > > > > > > > does anyone object to this ? > > > > > > > > Pavel, are you ok with this being reverted or do you want to submit= a > > > > patch that puts this behind some runtime flag ? > > > > > > > > > > yeah, you can revert it ... Once I have the runtime flag implemented = I can > > > resubmit it all together. > > > > ok will revert >=20 > Is this still a plan? I was a bit undecided on this, i may have overestimated the problems this would cause. And nothing major broke, and noone else spoke up ... So I kind of conditionally droped this patch until someone else said someth= ing or something broke ... > I also see a memory leak after this change. > OSS-Fuzz testcase 5851268507828224. >=20 > Additionally, it looks weird to skip `mpegts_set_stream_info()` on > this pes, but a few lines below still use it in > `av_program_add_stream_index()`. To me it looks like the change is not > fully complete, so I would propose to revert until fixed. feel free to revert it or fix it. But please make sure it gets into release= /8.0 thx [...] --=20 Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Those who would give up essential Liberty, to purchase a little temporary Safety, deserve neither Liberty nor Safety -- Benjamin Franklin --2zf80yvl5vv3Xl3h Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iF0EABEKAB0WIQSf8hKLFH72cwut8TNhHseHBAsPqwUCaKC1rAAKCRBhHseHBAsP qz4iAJ93KNIvTTZzVN7iErcajol39szQngCfSW1Vl0KCZjMqnlc/s3wrIWskBtY= =2pBl -----END PGP SIGNATURE----- --2zf80yvl5vv3Xl3h-- --===============7866360842234948260== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-request@ffmpeg.org with subject "unsubscribe". --===============7866360842234948260==--