From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id BA3BF4C210 for ; Thu, 9 Oct 2025 06:14:53 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'u6NkDraNNQyT8sDQL47/q7FtBjjrgDLMhs4MQ9BwJoQ=', expected b'VhZep6A48X4YXAzthJPuH0kqaIhVdwQkys/9AGL14y8=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759990486; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=u6NkDraNNQyT8sDQL47/q7FtBjjrgDLMhs4MQ9BwJoQ=; b=YVVrsn9eo4fj3eIvzhpieJ6llQ0xKcOEUdb68XG+o809Z8BjHFKN+VdzYYLPVKQmaeWX9 9xR/e8mSpDpFUaniCCuategAkyZ2IzBfMUtwBW+sVMzRPrHf9YY/1Su/LuaWvsjYZ487SA8 GjguLp5iboGeO74w2w1IiUvKLyfmha4LZuyiB6N+eZrmEOGICPPeFWSH2eqRh/GEC/xkbny ssEju3o1j+X+wzNlyNlKiYLieGR2V33RXA5u2d9nLf0iC1+v2uzuBuMck2SJh5kt2bMSlHc e9y4li30ZhGj5pEK8uqymGqiM5Ii3wpieTXZALCWNu98DtGid/MjZpglJ65w== Received: from [172.18.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 7B25B68F1AC; Thu, 9 Oct 2025 09:14:46 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759990469; b=jVfLUNIIN5m5nmRoA2bdE+6gtsgTFXG+doSC70g0jE2zmMSkPP+Y3ZWk6jY6gUJtsetjQ lbR4Bx4qT3G8lx3WQzW8gRjULrZ6VWiw7fRrF4zEREQzCCiAla7lO7pP8OMOC7jr2ebaU8V 6TEIYRylunEwPkWGH4hPwIN4xXYx3JDtWWExiHHnbFZoaC88q6nUDfgYvt6D1tFt0cxBJeo 5MbNg11/DmBd+sFggJG9ckFHgRdf1UANughYPt+PLNzfxg96INW8NtMhIsd03zxwSBZtIVt E1s8N67dEgGZ/Va6NE3YrH+IsZQK+dfGfEUYwvw+1FHr5ftqIxu2VrOfM23g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759990469; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=KWYW4IN/wu95koUK0hfY2ypke0NG6Hw1vJkdur0IRMw=; b=cU2OCm/WFfH2aCD692yJX7dSNyhne3PhvAlI82QNFJ4I6p/ehfyeGTmvTT+HUKq7no1uF Z0oNgT0t8ntBvsxoOS18JxIV/geQeDNO2WBQJBFDH0/fXm0TrBWTk4QXAOUIU3VvQL62vOj PYko2NJK/wqBueku2rTCyUII37FTlcAaZCEUryuklmxI8lMfexzCedpeCsPO90xm1zbi0eC d+78FOYEO5MPxxMDBBRyFsMxxxz3m+lGVTgVFjg4iyp0TNDslrtBAhU+15dERCLGER6wzyc yHq0C53ialD+4zH8InEF6Lc7ECHXGtPhIvo/2wsr1Sk2wNuIS6AFAIP6+nng== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759990461; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=VhZep6A48X4YXAzthJPuH0kqaIhVdwQkys/9AGL14y8=; b=qp80511FKEFh/sdE7QjJiYeou3CC6c/ZOL8nbJrIpsQijVTHkoO5zDVdTF6NqEsga3+nG UQ237NF6eUlfPxJmwdv2VE25OXIXRD7LvgrMwH+aNmYMoBh1t40HIf5timjKq5Y0TDaZD4I VtbIyyulB9hpjzz74HhS4K3NLv/ICIxXhwZdJImFdGZB65X1zrMjeQWgZoTP98mXG3gH736 PXT7ehAqdAQjthel3hdY+25iwlbLFB3Pd2OV0NC0YOMW2C5D5MgdamhMAgP4FYXojy8kM6Y lVtbvZz9c9ECdvv+dHZ3ztgEf5BReI/OXsv2fkKxEU4SYaIG/J+VxbRt9UOA== Received: from be50bb5a3685 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id DB7CF68F11A for ; Thu, 9 Oct 2025 09:14:21 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Thu, 09 Oct 2025 06:14:21 -0000 Message-ID: <175999046201.65.6974406366132547626@bf249f23a2c8> Message-ID-Hash: VYYEUDEBINQ3NT6IYLQJA6YKRDZKXBYW X-Message-ID-Hash: VYYEUDEBINQ3NT6IYLQJA6YKRDZKXBYW X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] libavutil: fix memory leak of drmVersion (PR #20678) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: timblechmann via ffmpeg-devel Cc: timblechmann Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20678 opened by timblechmann URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20678 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20678.patch i had submitted this patch before via email, but git-send-email workflow was rather cumbersome. very happy to see i can submit a PR now --- address sanitizer showed some leaks of drmVersion structs. `vaapi_device_create` did not call drmFreeVersion in all possible code paths. >>From 6d9a92244faf365cf394cd7194cc3da5a0984276 Mon Sep 17 00:00:00 2001 From: Tim Blechmann Date: Wed, 25 Jun 2025 10:14:42 +0800 Subject: [PATCH] libavutil: fix memory leak of drmVersion address sanitizer showed some leaks of drmVersion structs. `vaapi_device_create` did not call drmFreeVersion in all possible code paths. --- libavutil/hwcontext_vaapi.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/hwcontext_vaapi.c b/libavutil/hwcontext_vaapi.c index 51af22a607..753dcf8905 100644 --- a/libavutil/hwcontext_vaapi.c +++ b/libavutil/hwcontext_vaapi.c @@ -1815,6 +1815,7 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device, "Failed to get DRM device info for device %d.\n", n); close(priv->drm_fd); priv->drm_fd = -1; + drmFreeVersion(info); continue; } @@ -1826,6 +1827,7 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device, drmFreeDevice(&device); close(priv->drm_fd); priv->drm_fd = -1; + drmFreeVersion(info); continue; } av_log(ctx, AV_LOG_VERBOSE, "Trying to use " @@ -1833,6 +1835,7 @@ static int vaapi_device_create(AVHWDeviceContext *ctx, const char *device, "with matching vendor id (%s).\n", n, vendor_id->value); drmFreeDevice(&device); + drmFreeVersion(info); break; } drmFreeVersion(info); -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org