From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 9FC7E4BFA5 for ; Tue, 7 Oct 2025 00:26:09 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'dwUNgxbF4XuPi7GvL46FonVNODfUcJPBq0m1vYKKqYs=', expected b'Ews+6aIumzJufw9w8abJQ6hbcdrXPMsOsJTMmDS+LXI=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759796761; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=dwUNgxbF4XuPi7GvL46FonVNODfUcJPBq0m1vYKKqYs=; b=lr1K8kinrVoTtdrR64RQBmoaPiJAqzCAV22y33+faTPuef/dz11AgJeDxrz5daNBha6gX EavfjJC6m6cY+yj0Dcnb43JsPzwQtenn/Rxecd/lS62k26FiCSLHodyf+twuU3baGsEpSbV UjM2uJ6VGecflMncShmF2dJHoe1BKOxk0kKS8iFdhvGae3VPmzkwagIkGbHLGEtEnG7+jme Q6rmpqnwiWQQHx3EwM6pKh6uOx9De/+CNaMu3D5SgaaD0vB5hUe4q3QdCIA568a1qL2jyI3 WgaQSXtwrILEg4SaJKdB1zv8qeKAQHHaDtIAgUSLLEk4eoQW2VznUwQMMmQA== Received: from [172.18.0.2] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 9809B68F063; Tue, 7 Oct 2025 03:26:01 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759796745; b=OwvQOAA6edo4txFp8IlJmjOat7jMV/Hs6fejq1KBqye6HZ0uQf4AVLdYEJ4RwoYysuBhl gZOafCbqzTOfH94v+7QX0GD8P59a8gQqBZCBN3n8s2WmV3wq29nm3I2lDxzSXn8EvZ1S4yk XveQa8KAgthxvkiduRrPGsJihPZdbEFzW/KxTXSLZhmdbGlqFNhnOpNBHQV4dSSehL9Aju+ sRm7WNAU6MOCRjGZ6CWWZjGAmvTdifC4K9eB/s3aoPJad+6OpujvkBbEHgNQBiCQXuOhTDP VSaycw9lK9S4KNCaL6CiFF0bOFpNNGZsnRNGwQZeD5kZQmS6cPOn8JC7CGKg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759796745; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=59XuTJxg2czh7EbQah01MrTaPSIVDonsxM7AvTHGwpc=; b=lTrcW5+VPKgOmz1G4ZJS010yaycG3ich2ygZtC7p35fF9QwgOwEVf1uOE/Sr5w/Wntewy TTu45U1sc1JNe0X4nkV+WLvi3UQh0btzFYz6lG0F00hxPE5HaEUXTNbGpyTEidUAX5dm0Ed IPwN1tkxID2fOiJYLpA5ABrhjtQ6yPYVMliSpYKmycp9XF8qJy3nhzoUto6uIgqa9u2Xgyy mZruRkR5Tq5lhTRTPKxa2oku+bDEbKAQAJlFdgWJsdoztVEMn4t9f1aTGU8m+ZVdKn9/5w6 yxy4KJ0ZRE9MLFj9bGKE/JGFTL64veutppal6z/TTKYH/OqUGPbSz3SQixkA== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759796737; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=Ews+6aIumzJufw9w8abJQ6hbcdrXPMsOsJTMmDS+LXI=; b=QRM35TDSDZdvefxVmXpRY/8U0yZ8Flklgqs+d23SpIzwN00SRhylgB0ktntW1yOXxakzo cTh0WXLtw2LGkN4H+ZzSmbkXujbb68wMrzn30X8CgQgPOaIU6O5vJTc3UGBtuVVdosDIo0U O1PCbTAcG3lBY1aMIYrAMd69833p4YCJ1K++pDBtCIv3Y9ujSBtGsJCoZ3DVM6lMwoYXt4Q bIunVvTiwjN9ekQDzt3rm/JJsuGNPf4eG3/je7hxlsYBUO+TzjW5irlXWpflBnqxX6Xuw4D W06DihvLEUS/RXDOZofQci95S+8ysPyHJDQ4TYc08tHNsB+bbd/04xejWOBQ== Received: from be50bb5a3685 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 990BF68EB8E for ; Tue, 7 Oct 2025 03:25:37 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Tue, 07 Oct 2025 00:25:37 -0000 Message-ID: <175979673774.65.10773446148404556407@bf249f23a2c8> Message-ID-Hash: SVBWPGF55EXZ2KA6JQA6SUTKXXD4R2G5 X-Message-ID-Hash: SVBWPGF55EXZ2KA6JQA6SUTKXXD4R2G5 X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/g723_1enc: Make min_err 64bit (PR #20658) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: michaelni via ffmpeg-devel Cc: michaelni Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20658 opened by michaelni URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20658 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20658.patch This fixes the case of leaving the struct uninitialized and crashing Untested, as no testcase Signed-off-by: Michael Niedermayer >>From 54e775f818592e54c7e0fe2603bfd15e9a8e24bb Mon Sep 17 00:00:00 2001 From: Michael Niedermayer Date: Tue, 7 Oct 2025 01:58:34 +0200 Subject: [PATCH] avcodec/g723_1enc: Make min_err 64bit This fixes the case of leaving the struct uninitialized and crashing Untested, as no testcase Signed-off-by: Michael Niedermayer --- libavcodec/g723_1.h | 2 +- libavcodec/g723_1enc.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/g723_1.h b/libavcodec/g723_1.h index 521f220b2a..f3cd32e37d 100644 --- a/libavcodec/g723_1.h +++ b/libavcodec/g723_1.h @@ -108,7 +108,7 @@ typedef struct HFParam { * Optimized fixed codebook excitation parameters */ typedef struct FCBParam { - int min_err; + int64_t min_err; int amp_index; int grid_index; int dirac_train; diff --git a/libavcodec/g723_1enc.c b/libavcodec/g723_1enc.c index ee5b0fe251..4fd4567a87 100644 --- a/libavcodec/g723_1enc.c +++ b/libavcodec/g723_1enc.c @@ -1013,7 +1013,7 @@ static void fcb_search(G723_1_ChannelContext *p, int16_t *impulse_resp, int pulse_cnt = pulses[index]; int i; - optim.min_err = 1 << 30; + optim.min_err = 1LL << 31; get_fcb_param(&optim, impulse_resp, buf, pulse_cnt, SUBFRAME_LEN); if (p->pitch_lag[index >> 1] < SUBFRAME_LEN - 2) { -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org