[FFmpeg-devel] [PATCH] avformat/mccenc: use Lavf version string instead of FFmpeg (PR #20655)

[FFmpeg-devel] [PATCH] avformat/mccenc: use Lavf version string instead of FFmpeg (PR #20655)

[James Almer via ffmpeg-devel]

PR #20655 opened by James Almer (jamrial)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20655
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20655.patch

The muxed subtitle is created by libavformat, and as such that's what should be reported. This is in line with the string we write for every other muxer.
After this change, the muxer will no longer be recompiled every time a commit is made.


>From 84f14baa5c9ad26e35e84f385fb6ae708adb989e Mon Sep 17 00:00:00 2001
From: James Almer <jamrial@gmail.com>
Date: Mon, 6 Oct 2025 10:32:15 -0300
Subject: [PATCH] avformat/mccenc: use Lavf version string instead of FFmpeg

The muxed subtitle is created by libavformat, and as such that's what should be
reported. This is in line with the string we write for every other muxer.
After this change, the muxer will no longer be recompiled every time a commit
is made.

Signed-off-by: James Almer <jamrial@gmail.com>
---
 libavformat/mccenc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/libavformat/mccenc.c b/libavformat/mccenc.c
index c64d53805d..1c291f75b2 100644
--- a/libavformat/mccenc.c
+++ b/libavformat/mccenc.c
@@ -23,6 +23,7 @@
 #include "avformat.h"
 #include "internal.h"
 #include "mux.h"
+#include "version.h"
 
 #include "libavcodec/codec_id.h"
 #include "libavcodec/smpte_436m.h"
@@ -30,7 +31,6 @@
 #include "libavutil/avassert.h"
 #include "libavutil/avstring.h"
 #include "libavutil/error.h"
-#include "libavutil/ffversion.h"
 #include "libavutil/log.h"
 #include "libavutil/macros.h"
 #include "libavutil/opt.h"
@@ -125,9 +125,9 @@ static int mcc_write_header(AVFormatContext *avf)
     const char *creation_program = mcc->creation_program;
     if (!creation_program) {
         if (avf->flags & AVFMT_FLAG_BITEXACT)
-            creation_program = "FFmpeg";
+            creation_program = "Lavf";
         else
-            creation_program = "FFmpeg version " FFMPEG_VERSION;
+            creation_program = LIBAVFORMAT_IDENT;
     } else if (strchr(creation_program, '\n')) {
         av_log(avf, AV_LOG_FATAL, "creation_program must not contain multiple lines of text\n");
         return AVERROR(EINVAL);
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org