Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
 help / color / mirror / Atom feed
From: "Martin Storsjö via ffmpeg-devel" <ffmpeg-devel@ffmpeg.org>
To: ffmpeg-devel@ffmpeg.org
Cc: "Martin Storsjö" <code@ffmpeg.org>
Subject: [FFmpeg-devel] [PATCH] movenc: Check for more options incompatible with hybrid_fragmented (PR #20651)
Date: Mon, 06 Oct 2025 13:16:09 -0000
Message-ID: <175975657029.65.13259841181775501474@bf249f23a2c8> (raw)

PR #20651 opened by Martin Storsjö (mstorsjo)
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20651
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20651.patch

This follows up on c79bce92b8407199b6e70205393411650e4342ca with
more options that don't work together with hybrid fragmentation.


From 36f0efda74f306465c7bc10cadc1ad0e81909aa9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Martin=20Storsj=C3=B6?= <martin@martin.st>
Date: Fri, 27 Jun 2025 14:53:02 +0300
Subject: [PATCH] movenc: Check for more options incompatible with
 hybrid_fragmented

This follows up on c79bce92b8407199b6e70205393411650e4342ca with
more options that don't work together with hybrid fragmentation.
---
 libavformat/movenc.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavformat/movenc.c b/libavformat/movenc.c
index 067d38b14b..f586a442b2 100644
--- a/libavformat/movenc.c
+++ b/libavformat/movenc.c
@@ -7858,8 +7858,10 @@ static int mov_init(AVFormatContext *s)
         mov->flags |= FF_MOV_FLAG_FRAGMENT;
 
     if (mov->flags & FF_MOV_FLAG_HYBRID_FRAGMENTED &&
-        mov->flags & FF_MOV_FLAG_FASTSTART) {
-        av_log(s, AV_LOG_ERROR, "Setting both hybrid_fragmented and faststart is not supported.\n");
+        (mov->flags & (FF_MOV_FLAG_FASTSTART | FF_MOV_FLAG_DELAY_MOOV) ||
+         mov->reserved_moov_size > 0)) {
+        av_log(s, AV_LOG_ERROR, "The hybrid_fragmented mode is incompatible "
+                                "with faststart, delay_moov and moov_size.\n");
         return AVERROR(EINVAL);
     }
 
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org

                 reply	other threads:[~2025-10-06 13:16 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=175975657029.65.13259841181775501474@bf249f23a2c8 \
    --to=ffmpeg-devel@ffmpeg.org \
    --cc=code@ffmpeg.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Git Inbox Mirror of the ffmpeg-devel mailing list - see https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://master.gitmailbox.com/ffmpegdev/0 ffmpegdev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 ffmpegdev ffmpegdev/ http://master.gitmailbox.com/ffmpegdev \
		ffmpegdev@gitmailbox.com
	public-inbox-index ffmpegdev

Example config snippet for mirrors.


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git