From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 7FC894BD97 for ; Thu, 2 Oct 2025 22:22:16 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'AQUeVTwPAuGUEkM9MOwLMPHl8Wb2Je4GzwistsKZo5s=', expected b'Ymh6er0S7PqMrdAFPkA9rXWq+UWeH5C9lcszlirOGZA=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759443728; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=AQUeVTwPAuGUEkM9MOwLMPHl8Wb2Je4GzwistsKZo5s=; b=rxTA60jrRwHmDADzDR8GzND8AJIkp4hpaf5PUmNGWE5DRVOa6ru9BXS2MaL6tvA1r9DoM VKsusQqNUQqBXQAb13P1PvVzG6JsKVC4rWXvDWtH8OJgPGOqpfFE0uNg73ZR6WAc3H15pi0 wfItUzBDX8razMYuJG+wBCsSTjJ17CW2wVxLSLh6taszby7bReAyUncxfjNILfCeV431dVC u96CfFaNFyHtLbmDXw0pLZf1Tm7RYYaHy0giXAR1NgfdjW44QT+VY/r1NbeDtMys+E41oa6 2sO8PirmzzBdKCGBXg5HBWv2rTPTbNOuH2nwwl507hnqEa0fSLEM4B3YKqyQ== Received: from [172.19.0.2] (unknown [172.19.0.2]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 2C35C68EFD3; Fri, 3 Oct 2025 01:22:08 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759443715; b=YIRxQDwtM0ldLyjMm43glL5WJThv/1z8nKHs3mXoxrbKzqNGbvS/mV8I0Q/cFEUM3NnGm 1847xTzEqzMRajtMN/kvBHDb+hf9eT9MvXDK8xLx+OcOHpv5EuckVSkji0ZDk5n5a1zosFn hJAnXTmKr6GVf566CqDNE1bAZk2qV2H5zOu4V7e/dXeUnGzwCOa4rRrOFGueMP8owG5YFWl 0EcvYjHW39UTvyWoCJckyCL+TlbcKOzoaAyvMMq4N0xn8dlKlgDm1YoR2Q4ppqTqqBjSCjw 5bznmuKajPLdfPG3BPZUsyqXCSz3sIVcSNomDVyGIqP5kWMDvt12rxOrJQCw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759443715; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=3M8Kf4/AOwu4XU5ObCCdHbVRlgf397ZxSVeEguHjP/8=; b=rT1ptjnnuGyzAnjcfA6f2akqUnB+yd8O1L2caSpveMwxkEffAvYR00v7tJ3cbYQW/xVFF YoV7tC23fBFkwju17EBKuYIv0q2KectSuW9ftYRMSferbsoG+qsFsejw7CNmdHzByVlYXOh 045vMQ922e/yr2Gsg4P94kkoXpI4Bk0jJgNaFzWa9PrfUp2NZCbZVpEZOg8jf4d0SOrsZyJ 7WfUdMT44CKf01sK1PLls/ykksrTl/z9KZXJj1y4t60umLgnvhT/Ug+It9EpuwfWqvbDUwj GQh6kThR2Sk1bm887jwYc+fZZthfOB4X4wbfAiXetn2G5RWT7evlsyrBOFNw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759443709; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=Ymh6er0S7PqMrdAFPkA9rXWq+UWeH5C9lcszlirOGZA=; b=nBrxX2PXQfIB0FmMGCfA4y6bumq1dZUw3Mqazab8Z0+5/O/uwUrh051z9FQux93wwP3sF Wx7tAuIVkdE5b0upcWF7nF8xB6MnkuPIP2/LVGCNjA98jqyXaLXEX2DqPmjFif4kXZfh4Kc Vw2c50Dxuotc5ccjWY6JMkv9Lk1oC+Epxx6yDyr5O4BE+nZWevpeP66tGOfQHYprBQYM/Y6 eyJDW5HSSqEdPvKQCqH2FMy7QYWGUTPRn9xnIE6P9xrH4LslXEOMPotdwC+07ae5/JoE2qn 0ymwoSHMxUL81zsyWDeUfEdgIvDj7aqSlsUQCUH1AjPe4tfydoLmhtfMrdqQ== Received: from be50bb5a3685 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id B44F968EAD3 for ; Fri, 3 Oct 2025 01:21:49 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Thu, 02 Oct 2025 22:21:49 -0000 Message-ID: <175944370986.69.17679295915357367876@bf249f23a2c8> Message-ID-Hash: TDHFX47GDJZ3P25KZHWO56NWICGYG4ZE X-Message-ID-Hash: TDHFX47GDJZ3P25KZHWO56NWICGYG4ZE X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/pngenc: Mark unreachable default switch cases as such (PR #20641) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: mkver via ffmpeg-devel Cc: mkver Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20641 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20641 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20641.patch >>From 2eb23623c006631e4201e57360a70f2d30a72da9 Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Thu, 2 Oct 2025 21:07:48 +0200 Subject: [PATCH] avcodec/pngenc: Mark unreachable default switch cases as such Signed-off-by: Andreas Rheinhardt --- libavcodec/pngenc.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c index 5baad9aad5..8e4f42125e 100644 --- a/libavcodec/pngenc.c +++ b/libavcodec/pngenc.c @@ -195,6 +195,8 @@ static void png_filter_row(PNGEncContext *c, uint8_t *dst, int filter_type, dst[i] = src[i] - top[i]; sub_png_paeth_prediction(dst + i, src + i, top + i, size - i, bpp); break; + default: + av_unreachable("PNG_FILTER_VALUE_MIXED can't happen here and all others are covered"); } } @@ -816,6 +818,9 @@ static int apng_do_inverse_blend(AVFrame *output, const AVFrame *input, palette[*background] >> 24 == 0) break; return -1; + + default: + av_unreachable("Pixfmt has been checked before"); } memmove(output_data, foreground, bpp); @@ -1193,7 +1198,7 @@ static av_cold int png_enc_init(AVCodecContext *avctx) s->color_type = PNG_COLOR_TYPE_PALETTE; break; default: - return -1; + av_unreachable("Already checked via CODEC_PIXFMTS"); } s->bits_per_pixel = ff_png_get_nb_channels(s->color_type) * s->bit_depth; -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org