From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5657A4BABE for ; Mon, 29 Sep 2025 15:04:52 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'2E9OgK/3kPQ+cUitQzV2DPmTDEilezxsiR4qSHn3zUs=', expected b'subjVyDPIZxTzzzPAd3DQXZintRe9+UN0ri4fG6m+w4=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759158279; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=2E9OgK/3kPQ+cUitQzV2DPmTDEilezxsiR4qSHn3zUs=; b=YmQJ4eNbDftoUQqSiIGzBPBQz7MCzcL+hK0Wj3XyY17pqInFozjYY/KTyAuJnNcbKibxn unqEcYx9j4K/cga0bEEPNUqxjM8+d7IRGJRJ+klgmA9A74NCbQjzqKqCb1cDh7UOz3AG/b/ 8rjhd+JqNWVeKCyNEKdNB0atK5oNOhFgmQkriE+ElseY/tfS5RimA8Bt1bqV94nISxRebLe Yxtun/e4XfKb5e/Y7RQVD57uYJBkhG4wh8LKEk5chVIL3YAp/qMaXDUMiB61NlM85IHd7jQ pRZlMYBa9F61y1hACuCy4E/QuT/j90x8p7RsQ3esRl7jkm3riQp8ysZ39bmw== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 258FC68EE82; Mon, 29 Sep 2025 18:04:39 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1759158274; b=DcC6Q1bfXYFgogJ2xXbmad67NRv5s/Fy8z2g82TM/9H7h7CwQ3mZ7i4hntYErbt/3M2VY SKREfDrYKOjruppEjOxHz999QSLamrB5PNdeMSekNbDroJKTXTNzS7LExeFgp4mlnBYeDkM H0Tq/UvOrLElztBIGRiurVRcRLBnX1B6gkRy5ALUzqCl/qJqkTpIO4pkredj4Umv/ETd4v9 G68VJzuU+V4BzI8A4u6W3tYd1PNKa8KCdVyG7zML3Qth/yijqNW3BhkP1kDjCoa5fltq22Y rH8RtEIlADFT6aa2GLFAsfYFlQv1zBkrJ+YO2gf9HeKNmIr5+mxa0ZXZ6vXg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1759158274; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=BG9+oi3oYS/gGpRcrlK3jvDS8M/FGGul9Fn+rSTCpiw=; b=fDze2XYOqL9d3Dc0rJeXkc8oOuDvcduxBSFXKTHDvRMi+wycW5EEIz6OSpBL3pKzqaakz QpuMkwnzhohXJbwGm1nsXDwB8VCcKD9euZrUe50PMin/No7kDx6uMQ3Nz/Lb6JgybMltys8 mknvrdRe6/+6tio79EPpAyUB7Ami88WADGoeeai+A65GqGG7NERR9IpYr1UtORcJDwsTqdp uv0/ZKk3PChHzabjJ+to4vvCS4dM26G8GokfhmShKuz/6+PnPVuqP+o77hDQKCp6WHjMC+r qzuNCOVx8uiT8pa1eQxbje79f/S1jEgiINrRJxbFHhpaPN2iOFI8eU0hHp3w== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1759158265; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=subjVyDPIZxTzzzPAd3DQXZintRe9+UN0ri4fG6m+w4=; b=KNR1SQuezFMf0gumJ6vJ84UDBs8sa4WKXoVapkwEyLItWDr6mUgs0VI9nZsMvbxNWV6Oc /6WCaoNX9KBxK9cO+aI8Y7xV6eWyWb3MhRtl84/EB6HAMMnzDQOx9F9y/ZtOwxn9WDCwZXK XvP3KwO/KBHCP/Mec5LS3LFcPz9tfK06bwnekvKLWDnpcqbpwSL3xR3y/T3k34CIbuttOz8 rUGwTeb70UceSYhliLN5ufd6BVre8yDNzBn+jWxRJW+I9aYz8odrbftIp+TgAMj9ewCvm26 5FP+/zR8hlwUOyt5kbqaJR28eEOMEAGi8CTg07rk75DUqgSBFuRe+/NBfkzA== Received: from 13289e625de8 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 164BF68EE5D for ; Mon, 29 Sep 2025 18:04:25 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Mon, 29 Sep 2025 15:04:24 -0000 Message-ID: <175915826520.25.4263526844597699342@bf249f23a2c8> Message-ID-Hash: MOXLWZHVG2TAHD3ONAV7MP3WYJZK6C3U X-Message-ID-Hash: MOXLWZHVG2TAHD3ONAV7MP3WYJZK6C3U X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] Miscellaneous aacdec_usac cleanups (PR #20627) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Lynne via ffmpeg-devel Cc: Lynne Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20627 opened by Lynne URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20627 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20627.patch Nothing major. >>From 485939f5ba2051d3091bb130f0879d3b1ed83e6a Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 30 Sep 2025 00:02:19 +0900 Subject: [PATCH 1/2] aacdec_usac: memset uncoded coeffs instead of iterating Microoptimization. --- libavcodec/aac/aacdec_usac.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index c4b821bbba..38d5328029 100644 --- a/libavcodec/aac/aacdec_usac.c +++ b/libavcodec/aac/aacdec_usac.c @@ -670,10 +670,8 @@ static int decode_spectrum_ac(AACDecContext *s, float coef[1024], ff_aac_ac_finish(state, i, N); - for (; i < N/2; i++) { - coef[2*i + 0] = 0; - coef[2*i + 1] = 0; - } + /* Zero out uncoded coeffs */ + memset(coef + 2*i, 0, N*sizeof(*coef))); /* Signs */ for (i = 0; i < len; i++) { -- 2.49.1 >>From 5ab2d1762dbfa6d68b6fdc2048b73d9345453a54 Mon Sep 17 00:00:00 2001 From: Lynne Date: Tue, 30 Sep 2025 00:02:51 +0900 Subject: [PATCH 2/2] aacdec_usac: minor code cleanups --- libavcodec/aac/aacdec_usac.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavcodec/aac/aacdec_usac.c b/libavcodec/aac/aacdec_usac.c index 38d5328029..9ecbfecb35 100644 --- a/libavcodec/aac/aacdec_usac.c +++ b/libavcodec/aac/aacdec_usac.c @@ -1152,8 +1152,8 @@ static void complex_stereo_interpolate_imag(float *im, float *re, const float f[ s = f[6]*re[0] + f[5]*re[0] + f[4]*re[1] + f[3]*re[2] + f[2]*re[3] + f[1]*re[4] + f[0]*re[5]; - im[i] += s*factor_even; + for (i = 3; i < len - 4; i += 2) { s = f[6]*re[i-3] + f[5]*re[i-2] + f[4]*re[i-1] + f[3]*re[i] + @@ -1447,11 +1447,10 @@ static int decode_usac_core_coder(AACDecContext *ac, AACUSACConfig *usac, memset(&sce->coeffs[0], 0, 1024*sizeof(float)); for (int win = 0; win < ics->num_windows; win++) { int lg = ics->swb_offset[ics->max_sfb]; - int N; + + int N = usac->core_frame_len; if (ics->window_sequence[0] == EIGHT_SHORT_SEQUENCE) - N = usac->core_frame_len / 8; - else - N = usac->core_frame_len; + N >>= 3; ret = decode_spectrum_ac(ac, sce->coeffs + win*128, gb, &ue->ac, arith_reset_flag && (win == 0), lg, N); -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org