From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 721344B712 for ; Wed, 24 Sep 2025 03:05:58 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'xa7rW3B3AxTzpfA3nTxbXal2XPz6zahn+grfwLuo6OQ=', expected b'Hg4JsVPPHUnKnzREQf/bb13iYcnPu+JCFZzmBvgp6WI=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1758683150; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=xa7rW3B3AxTzpfA3nTxbXal2XPz6zahn+grfwLuo6OQ=; b=FQDUvJvYAHgrAluANR9XcJ3b1v4CkJCZRcAjgRHDp0lPLQuIsKNfZfWa0eotxcmpoH4DC LoTVvazTScLlSaO0iHiYQ5TxMaW+NxMEINcQB+ds2O/4iRm1XAH6GSKPo03xCL/IwDDSQOm kP2sFJV+hvf9JE4xsh4+AsbB5k8LewLeS6iRA6TEjTHrEgWv/1UZNE87Ux4Aa7XhAuNb2eZ tl1ASh/SJ9X9ilaMD8MWm1Sa41/HTxe7nJTkGosmW9WZQOHG2A4oT7puFvMyAZt2bk3OTZO 4a8urfcdWgfaLsN+PdF8AuPY6gIOXrKjpA7wJmXVxuFBp9KXqSBoVQvHxGbw== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 0D65E68EBF0; Wed, 24 Sep 2025 06:05:50 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1758683147; b=R2aEBz1mNdaQclaiVmH9Tl1qxiJKt2Y+c1iwcGlrAkE46dFr6fCk1vWsl1dOxUFlBZXYq NyK5RnMRXvCmrxj9dMnbmmYP1awVPcN1YrtDCrFznbHzqPD8UEjVgM9R1M2N05SWKdXpXT5 3T0g53hs6UkeXEDYO75PbZVtHBe6txBM2Pmdf7k3kCWWLQB0o9pqtSDri4yNn99F5Xl68yE Tz4CQ73iWKQMsJJ4Agm9RCxR3fr7aKqkU6FzKbB4QDUSvIMgcy+4tJbkIT9l28MWJlub270 8nwpElWRq3yN+1f00AVOBD4B2zcwE0gsBIQfX4U1JzysBBqUefJFO4RwUj2g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1758683147; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=qcBtmG3njyBNTwtcH8LG/u+dOhxEscGkDtH6e0IRq48=; b=jIYUHRMzECVWuV4Eq1djKzwpTbP3uN51eU00MhtTO+gkZAJ0tl+COrxSZR5QhvYchCwaL hHyfsb2e27PM9mbrfGfgRla3tsHb3dRsBpWUbGc5pRriPvhkhQzbOfH09vur+ePiroZlpUv 6HPuRrLd5yHRskwUNbpliPfDdQfXFYW23BN9kC0P7ro7KBuVjRILO6MoNJa0tpYqSrNENtS PlnFuSTmhGyoiNP9qvS+Cw0lHv1iUg58RbtNEKHA62NhQalZDqZ/sFSihm/aMyhcRD2zKEz u4Nx/iZPwl+Td0632bjxg68JN1qlIOTlhZIuqUtCa+woj7KJ7P8/qKuMlXDw== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1758683139; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=Hg4JsVPPHUnKnzREQf/bb13iYcnPu+JCFZzmBvgp6WI=; b=k5HM/MRWkqV9AzBk6I71/oWU/t3DgLTf/MtwGTQUvy1kZioL5aJHODMZks/9HMmKclSeA cpMQQKFFopL2koAqLNh1YKdHN2MdqQMHeJ3R37PRKoMIZGu5s3F3OOyXryHirWc5W//Rfk1 7caSIs6hdgnTeEA+0aUfWTmwrfqevZCYEtymFdTLRxHEByh0vFGbfsRjTL6YrYFbxS06+3Y lhgylJR121YrnWxeMQjKQJIAxTWHFB4TD3P1peJxN1rWo4mWrimjsII19gAfk4yLMnDv/JF UV7x1XOzL4FwrL3ZQuR7RMTjYsiTolQ5TrgmQeJkitQAEB1R4dyg4Btsxztg== Received: from ed19c606a818 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 160DA68EBAE for ; Wed, 24 Sep 2025 06:05:39 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Wed, 24 Sep 2025 03:05:38 -0000 Message-ID: <175868313922.25.4902341291989168085@bf249f23a2c8> Message-ID-Hash: CSIUSDNLYQ3X7ZXF5RCB3QCJLCDDNWYU X-Message-ID-Hash: CSIUSDNLYQ3X7ZXF5RCB3QCJLCDDNWYU X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avcodec/tiff_common: Remove unused ff_tadd_*_metadata() funcs (PR #20592) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: mkver via ffmpeg-devel Cc: mkver Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20592 opened by mkver URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20592 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20592.patch Unused since ad77345a5d14862f4701e5ad422b03b14934a5b9. >>From 6bd29f31912942e10c4d03ce180ea34baaaef08f Mon Sep 17 00:00:00 2001 From: Andreas Rheinhardt Date: Wed, 24 Sep 2025 05:01:04 +0200 Subject: [PATCH] avcodec/tiff_common: Remove unused ff_tadd_*_metadata() funcs Unused since ad77345a5d14862f4701e5ad422b03b14934a5b9. Signed-off-by: Andreas Rheinhardt --- libavcodec/tiff_common.c | 67 ---------------------------------------- libavcodec/tiff_common.h | 18 ----------- 2 files changed, 85 deletions(-) diff --git a/libavcodec/tiff_common.c b/libavcodec/tiff_common.c index ee8061944b..265f843031 100644 --- a/libavcodec/tiff_common.c +++ b/libavcodec/tiff_common.c @@ -97,51 +97,6 @@ static int bprint_to_avdict(AVBPrint *bp, const char *name, return av_dict_set(metadata, name, ap, AV_DICT_DONT_STRDUP_VAL); } -int ff_tadd_rational_metadata(int count, const char *name, const char *sep, - GetByteContext *gb, int le, AVDictionary **metadata) -{ - AVBPrint bp; - int32_t nom, denom; - int i; - - if (count >= INT_MAX / sizeof(int64_t) || count <= 0) - return AVERROR_INVALIDDATA; - if (bytestream2_get_bytes_left(gb) < count * sizeof(int64_t)) - return AVERROR_INVALIDDATA; - - av_bprint_init(&bp, 10 * count, AV_BPRINT_SIZE_UNLIMITED); - - for (i = 0; i < count; i++) { - nom = ff_tget_long(gb, le); - denom = ff_tget_long(gb, le); - av_bprintf(&bp, "%s%7"PRId32":%-7"PRId32, auto_sep(count, sep, i, 4), nom, denom); - } - - return bprint_to_avdict(&bp, name, metadata); -} - - -int ff_tadd_long_metadata(int count, const char *name, const char *sep, - GetByteContext *gb, int le, AVDictionary **metadata) -{ - AVBPrint bp; - int i; - - if (count >= INT_MAX / sizeof(int32_t) || count <= 0) - return AVERROR_INVALIDDATA; - if (bytestream2_get_bytes_left(gb) < count * sizeof(int32_t)) - return AVERROR_INVALIDDATA; - - av_bprint_init(&bp, 10 * count, AV_BPRINT_SIZE_UNLIMITED); - - for (i = 0; i < count; i++) { - av_bprintf(&bp, "%s%7i", auto_sep(count, sep, i, 8), ff_tget_long(gb, le)); - } - - return bprint_to_avdict(&bp, name, metadata); -} - - int ff_tadd_doubles_metadata(int count, const char *name, const char *sep, GetByteContext *gb, int le, AVDictionary **metadata) { @@ -184,28 +139,6 @@ int ff_tadd_shorts_metadata(int count, const char *name, const char *sep, return bprint_to_avdict(&bp, name, metadata); } - -int ff_tadd_bytes_metadata(int count, const char *name, const char *sep, - GetByteContext *gb, int le, int is_signed, AVDictionary **metadata) -{ - AVBPrint bp; - int i; - - if (count >= INT_MAX / sizeof(int8_t) || count < 0) - return AVERROR_INVALIDDATA; - if (bytestream2_get_bytes_left(gb) < count * sizeof(int8_t)) - return AVERROR_INVALIDDATA; - - av_bprint_init(&bp, 10 * count, AV_BPRINT_SIZE_UNLIMITED); - - for (i = 0; i < count; i++) { - int v = is_signed ? (int8_t)bytestream2_get_byte(gb) : bytestream2_get_byte(gb); - av_bprintf(&bp, "%s%3i", auto_sep(count, sep, i, 16), v); - } - - return bprint_to_avdict(&bp, name, metadata); -} - int ff_tadd_string_metadata(int count, const char *name, GetByteContext *gb, int le, AVDictionary **metadata) { diff --git a/libavcodec/tiff_common.h b/libavcodec/tiff_common.h index 11f2e739a4..67f23bd4fa 100644 --- a/libavcodec/tiff_common.h +++ b/libavcodec/tiff_common.h @@ -62,18 +62,6 @@ double ff_tget_double(GetByteContext *gb, int le); /** Reads a byte from the bytestream using given endianness. */ unsigned ff_tget(GetByteContext *gb, int type, int le); -/** Adds count rationals converted to a string - * into the metadata dictionary. - */ -int ff_tadd_rational_metadata(int count, const char *name, const char *sep, - GetByteContext *gb, int le, AVDictionary **metadata); - -/** Adds count longs converted to a string - * into the metadata dictionary. - */ -int ff_tadd_long_metadata(int count, const char *name, const char *sep, - GetByteContext *gb, int le, AVDictionary **metadata); - /** Adds count doubles converted to a string * into the metadata dictionary. */ @@ -86,12 +74,6 @@ int ff_tadd_doubles_metadata(int count, const char *name, const char *sep, int ff_tadd_shorts_metadata(int count, const char *name, const char *sep, GetByteContext *gb, int le, int is_signed, AVDictionary **metadata); -/** Adds count bytes converted to a string - * into the metadata dictionary. - */ -int ff_tadd_bytes_metadata(int count, const char *name, const char *sep, - GetByteContext *gb, int le, int is_signed, AVDictionary **metadata); - /** Adds a string of count characters * into the metadata dictionary. */ -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org