From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from ffbox0-bg.ffmpeg.org (ffbox0-bg.ffmpeg.org [79.124.17.100]) by master.gitmailbox.com (Postfix) with ESMTPS id 5B2364B2D0 for ; Tue, 23 Sep 2025 14:23:01 +0000 (UTC) Authentication-Results: ffbox; dkim=fail (body hash mismatch (got b'PIoYgFMOrdAaSx3frv9MXRh0ZKh5UphgkObAVXV0Mvg=', expected b'upMmpzYQDfgHbOUFAQy87B/Cw1JmAmK29Ib6Z46DJ/U=')) header.d=ffmpeg.org header.i=@ffmpeg.org header.a=rsa-sha256 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1758637374; h=mime-version : to : date : message-id : reply-to : subject : list-id : list-archive : list-archive : list-help : list-owner : list-post : list-subscribe : list-unsubscribe : from : cc : content-type : content-transfer-encoding : from; bh=PIoYgFMOrdAaSx3frv9MXRh0ZKh5UphgkObAVXV0Mvg=; b=Ivjj6Nx1FxPTBI+liygzrmZVXAilsz7kcw/1VASBgU0IzXGIItciKxqO6Pj89jfeXhlrQ gUmPIJ+fK1qgz9jFH7v/J1IIU7KaHLbkRwa+tXGN3d7dCVeHvEcKj8Uxpl/ruzGzQRVGedC 5Uzwl98jN7vFR8yeluaNf/IxqMQ+LgTaAACfs7sEa15nXmdbeywLhmrPe4cvVxIXBxMpRSW g3Lqjz8bwawHM6u57vT4UUFEBJLHsCxlh0MNJeH9KQQDuNI17HoLKynSt+MrAdPaiDWL9fz QdMXKRd3opRRLPczK0rvD8U5QFeva2BJwNWR3i6mlAAl1izG2LRBqe/TNqgg== Received: from [172.19.0.4] (unknown [172.19.0.4]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTP id 1E22868EBBF; Tue, 23 Sep 2025 17:22:54 +0300 (EEST) ARC-Seal: i=1; cv=none; a=rsa-sha256; d=ffmpeg.org; s=arc; t=1758637372; b=jvh2DvG7iVH/3Y1R2LKUNykjQhkwFHS+q1exnx+70IPU7JdvY1g+2glIvS6U+CHfXkAjF Nv9B1wM1it8/Hfn/QnkTzJG/LsHV6SrxJDu0W4pmHLuktla0hgZpQaWBoLzR7TtgvGQBcfT OkZQqcjk7gXNdKfqno7g0gqKojoHf3nKZwBSywB7X6Z282o0PLkhJLXZnK9nQ97Kb7DwCFu 5O7ZJIJu/uf3nfHeDd9AnEe48A6X6kp6eqPlI2TnynOlSMf5jhkxZZ5A6QMLzHjjHl5ijbR RPRV18eHsjp6MF7V/6cSyGrY+oKKxk+l19A15etMqh54J7OWxIqJ2ZRGMY4g== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=ffmpeg.org; s=arc; t=1758637372; h=from : sender : reply-to : subject : date : message-id : to : cc : mime-version : content-type : content-transfer-encoding : content-id : content-description : resent-date : resent-from : resent-sender : resent-to : resent-cc : resent-message-id : in-reply-to : references : list-id : list-help : list-unsubscribe : list-subscribe : list-post : list-owner : list-archive; bh=I7wdhB3LuUy6oGNJI+qyyDYSx21KMwBSb/1W6ajnZ9A=; b=aG/0dWpZC2nwWUTgEEu1SWjFKaVrFqFmNQNCJvOw0igNTJyUe15vE9IgHKgi87DSK0l5f wwD27RcwUNJc9yN6P8riSf3UgcGi/IQL7mGSq9He2qeyd954vc42qMiutE++daRFCgMb8AL BpKwW0emGNIdIdZQ07gR8vYsalC2gubC6nImeEUc+46B32tfbU3cNznb6uCOcK8I9nJoZeh pVxqejhJlts6SqvHaFd/JqcqFDeZywi4j2LU7YuTpqnxTMDXRpdFBanI+pp8CA3KTFedzg4 H5+daDrd8aJ9i/f2YhoN26l9d0ggmLCDUZslMO8qzd2yYoOY/Z3dVcJIfFkg== ARC-Authentication-Results: i=1; ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none; dmarc=pass header.from=ffmpeg.org policy.dmarc=quarantine Authentication-Results: ffmpeg.org; dkim=pass header.d=ffmpeg.org header.i=@ffmpeg.org; arc=none (Message is not ARC signed); dmarc=pass (Used From Domain Record) header.from=ffmpeg.org policy.dmarc=quarantine DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ffmpeg.org; i=@ffmpeg.org; q=dns/txt; s=mail; t=1758637364; h=content-type : mime-version : content-transfer-encoding : from : to : reply-to : subject : date : from; bh=upMmpzYQDfgHbOUFAQy87B/Cw1JmAmK29Ib6Z46DJ/U=; b=XwPD/AyEiPzhfQJc5IhozWElLLJKaKoI92QKItJUSmWey3REtRPFj4oiTpsl3gwI2U8j/ OTnUTit8WafdxED30yySrD2O3lzYfI/4hqRmZ9KArq2S6JIEQ1t+XXdOni8yzXC19kAN8xn YISInLit+fli1xvwlmqSzB3rCsdUQu5/YF4qZ916WLc67dsojsxXyq4Jj3yoiSltYOefXrB CSy2VdPDpAzRpkNYVbsNFm3/W1jwN1VAToDrXhXhhOp+1lpj5eYROS7wFqW0bBjH3xENgN3 Kg/enuLLQ0RhzjDF4nd0SqChoYQ0RU/tyvJ3z401jo+78SlwLvAgqFUxqJNw== Received: from ed19c606a818 (code.ffmpeg.org [188.245.149.3]) by ffbox0-bg.ffmpeg.org (Postfix) with ESMTPS id 916CC68EBAB for ; Tue, 23 Sep 2025 17:22:44 +0300 (EEST) MIME-Version: 1.0 To: ffmpeg-devel@ffmpeg.org Date: Tue, 23 Sep 2025 14:22:44 -0000 Message-ID: <175863736472.25.7459974248998340640@463a07221176> Message-ID-Hash: NQVB24YHALDNKL4WNJRZTDN2KFCQMOCL X-Message-ID-Hash: NQVB24YHALDNKL4WNJRZTDN2KFCQMOCL X-MailFrom: code@ffmpeg.org X-Mailman-Rule-Misses: dmarc-mitigation; no-senders; approved; loop; banned-address; header-match-ffmpeg-devel.ffmpeg.org-0; header-match-ffmpeg-devel.ffmpeg.org-1; header-match-ffmpeg-devel.ffmpeg.org-2; header-match-ffmpeg-devel.ffmpeg.org-3; emergency; member-moderation; nonmember-moderation; administrivia; implicit-dest; max-recipients; max-size; news-moderation; no-subject; digests; suspicious-header X-Mailman-Version: 3.3.10 Precedence: list Reply-To: FFmpeg development discussions and patches Subject: [FFmpeg-devel] [PATCH] avformat/movenc_ttml: fix memleaks (PR #20586) List-Id: FFmpeg development discussions and patches Archived-At: Archived-At: List-Archive: List-Archive: List-Help: List-Owner: List-Post: List-Subscribe: List-Unsubscribe: From: Zhao Zhili via ffmpeg-devel Cc: Zhao Zhili Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Archived-At: List-Archive: List-Post: PR #20586 opened by Zhao Zhili (quink) URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20586 Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20586.patch Memory leaks can happen on normal case when break from while loop early, and it can happen on error path with goto cleanup. The two fate failures mov-mp4-ttml-stpp and mov-mp4-ttml-dfxp are the first case. >>From 278fa8c69d07a4519669c851f0a51a0695761983 Mon Sep 17 00:00:00 2001 From: Zhao Zhili Date: Tue, 23 Sep 2025 22:08:02 +0800 Subject: [PATCH] avformat/movenc_ttml: fix memleaks Memory leaks can happen on normal case when break from while loop early, and it can happen on error path with goto cleanup. The two fate failures mov-mp4-ttml-stpp and mov-mp4-ttml-dfxp are the first case. --- libavformat/movenc_ttml.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/movenc_ttml.c b/libavformat/movenc_ttml.c index c5232e589c..ff09c14fa2 100644 --- a/libavformat/movenc_ttml.c +++ b/libavformat/movenc_ttml.c @@ -140,7 +140,7 @@ static int mov_write_ttml_document_from_queue(AVFormatContext *s, } else if (pkt->pts >= end_ts) { // starts after this fragment, put back to original queue ret = avpriv_packet_list_put(&track->squashed_packet_queue, - pkt, av_packet_ref, + pkt, NULL, FF_PACKETLIST_FLAG_PREPEND); if (ret < 0) goto cleanup; @@ -215,6 +215,7 @@ static int mov_write_ttml_document_from_queue(AVFormatContext *s, ret = 0; cleanup: + av_packet_unref(pkt); while (!avpriv_packet_list_get(&back_to_queue_list, pkt)) { ret = avpriv_packet_list_put(&track->squashed_packet_queue, pkt, av_packet_ref, -- 2.49.1 _______________________________________________ ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org