[FFmpeg-devel] [PATCH] avformat/tls_openssl: Don't call functions inside FFMIN (PR #20576)

[mkver via ffmpeg-devel <ffmpeg-devel@ffmpeg.org>]

PR #20576 opened by mkver
URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20576
Patch URL: https://code.ffmpeg.org/FFmpeg/FFmpeg/pulls/20576.patch

It may call the function multiple times.


>From 5f80608feca66b611cf863b6f46357b32fd8709c Mon Sep 17 00:00:00 2001
From: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
Date: Mon, 22 Sep 2025 15:34:30 +0200
Subject: [PATCH] avformat/tls_openssl: Don't call functions inside FFMIN

It may call the function multiple times.

Signed-off-by: Andreas Rheinhardt <andreas.rheinhardt@outlook.com>
---
 libavformat/tls_openssl.c | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c
index edfd657a3f..86b4d21799 100644
--- a/libavformat/tls_openssl.c
+++ b/libavformat/tls_openssl.c
@@ -939,8 +939,10 @@ static int tls_write(URLContext *h, const uint8_t *buf, int size)
     uc->flags &= ~AVIO_FLAG_NONBLOCK;
     uc->flags |= h->flags & AVIO_FLAG_NONBLOCK;
 
-    if (s->is_dtls)
-        size = FFMIN(size, DTLS_get_data_mtu(c->ssl));
+    if (s->is_dtls) {
+        const size_t mtu_size = DTLS_get_data_mtu(c->ssl);
+        size = FFMIN(size, mtu_size);
+    }
 
     ret = SSL_write(c->ssl, buf, size);
     if (ret > 0)
-- 
2.49.1

_______________________________________________
ffmpeg-devel mailing list -- ffmpeg-devel@ffmpeg.org
To unsubscribe send an email to ffmpeg-devel-leave@ffmpeg.org